fixed test cases and added types to auth.spec ,db.spec

Author: PurnenduMIshra129th

src/lib/db.ts

@@ -10,8 +10,8 @@ let client: postgres.Sql;
 try {
 	client = postgres(DATABASE_URL, {
 		prepare: false,
-		max: 10, //Connection pooling
-		idle_timeout: 30, //auto-close idle connections
+		max: 10,
+		idle_timeout: 30,
 		ssl: process.env.API_POSTGRES_SSL_MODE === "true" ? "allow" : undefined,
 		...(process.env.NODE_ENV === "development" && {
 			debug: (connection, query, params) => {
@@ -27,10 +27,10 @@ try {
 	process.exit(1);
 }
 
-// ✅ Connect Drizzle ORM
+//Connect Drizzle ORM
 export const db = drizzle(client);
 
-// ✅ Graceful Shutdown Handler
+//Graceful Shutdown Handler
 const shutdownHandler = async () => {
 	console.log("Closing database connections...");
 	try {
@@ -42,6 +42,6 @@ const shutdownHandler = async () => {
 	process.exit(0);
 };
 
-// ✅ Listen for termination signals
+//Listen for termination signals
 process.on("SIGINT", shutdownHandler);
 process.on("SIGTERM", shutdownHandler);

test/lib/auth.spec.ts

@@ -1,8 +1,8 @@
+import type { MiddlewareInputContext, MiddlewareOptions } from "better-auth";
 import { beforeEach, describe, expect, test, vi } from "vitest";
 import { auth } from "~/src/lib/auth";
 import { db } from "~/src/lib/db";
 
-// Mock db.select for /sign-in
 vi.mock("~/src/lib/db", async () => {
 	const actual =
 		await vi.importActual<typeof import("~/src/lib/db")>("~/src/lib/db");
@@ -23,36 +23,10 @@ vi.mock("~/src/lib/db", async () => {
 		},
 	};
 });
-interface AuthContext {
-	path: string;
-	context: {
-		newSession?: {
-			user: {
-				id: string;
-				email: string;
-				name: string;
-			};
-			session: {
-				token: string;
-			};
-		};
-	};
-	json: (data: unknown) => void;
-}
 describe("auth.hooks.after", () => {
-	// let jsonMock: ReturnType<typeof vi.fn>;
-
-	// beforeEach(() => {
-	//     jsonMock = vi.fn();
-	// });
-
 	test("returns success for /sign-up", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-
-		// Create context object with the json spy method
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-up",
 			context: {
 				newSession: {
@@ -61,15 +35,9 @@ describe("auth.hooks.after", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Get the handler function
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		const handler = auth.options.hooks.after;
-
-		// Execute the handler with our mocked context
 		const result = await handler(ctx);
-
-		// Instead of checking if the mock was called, verify the returned result
 		expect(result).toEqual({
 			statusCode: "10000",
 			message: "Success",
@@ -81,10 +49,8 @@ describe("auth.hooks.after", () => {
 	});
 
 	test("returns user details for /sign-in", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-in",
 			context: {
 				newSession: {
@@ -97,9 +63,7 @@ describe("auth.hooks.after", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Execute the handler and check result
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		const result = await auth.options.hooks.after(ctx);
 
 		expect(result).toEqual({
@@ -118,34 +82,26 @@ describe("auth.hooks.after", () => {
 	});
 
 	test("returns error when no session", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-in",
 			context: {},
 			json: jsonMock,
-		};
-
-		// Execute the handler and check result
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		const result = await auth.options.hooks.after(ctx);
-
 		expect(result).toEqual({
 			statusCode: "10001",
 			message: "No active session",
 		});
 	});
 
 	test("returns failure on db error", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-
-		// Mock DB error
 		vi.mocked(db.select).mockImplementationOnce(() => {
 			throw new Error("DB fail");
 		});
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+
+		const ctx = {
 			path: "/sign-in",
 			context: {
 				newSession: {
@@ -158,11 +114,8 @@ describe("auth.hooks.after", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Execute the handler and check result
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		const result = await auth.options.hooks.after(ctx);
-
 		expect(result).toEqual({
 			statusCode: "10001",
 			message: "Failure",
@@ -172,23 +125,17 @@ describe("auth.hooks.after", () => {
 });
 
 describe("auth.hooks.after error handling", () => {
-	// Spy on console.error to verify it's called during error handling
 	const consoleErrorSpy = vi
 		.spyOn(console, "error")
 		.mockImplementation(() => {});
 
 	beforeEach(() => {
-		// Clear the mock before each test
 		consoleErrorSpy.mockClear();
 	});
 
 	test("handles Error object correctly", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-
-		// Create context object that accesses newSession normally
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-in",
 			context: {
 				newSession: {
@@ -201,20 +148,12 @@ describe("auth.hooks.after error handling", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Force db.select to throw an Error object with a specific message
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		vi.mocked(db.select).mockImplementationOnce(() => {
 			throw new Error("Database connection failed");
 		});
-
-		// Execute the handler and check result
 		const result = await auth.options.hooks.after(ctx);
-
-		// Verify console.error was called
 		expect(consoleErrorSpy).toHaveBeenCalled();
-
-		// Verify the error response format with the specific error message
 		expect(result).toEqual({
 			statusCode: "10001",
 			message: "Failure",
@@ -223,12 +162,8 @@ describe("auth.hooks.after error handling", () => {
 	});
 
 	test("handles non-Error exceptions correctly", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-
-		// Create context object
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-in",
 			context: {
 				newSession: {
@@ -241,34 +176,22 @@ describe("auth.hooks.after error handling", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Force db.select to throw a string instead of an Error object
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		vi.mocked(db.select).mockImplementationOnce(() => {
 			throw "String exception";
 		});
-
-		// Execute the handler and check result
 		const result = await auth.options.hooks.after(ctx);
-
-		// Verify console.error was called
 		expect(consoleErrorSpy).toHaveBeenCalled();
-
-		// Verify the error response format matches the actual implementation
 		expect(result).toEqual({
 			statusCode: "10001",
 			message: "Failure",
-			error: "Unknown error", // Updated to match actual implementation
+			error: "Unknown error",
 		});
 	});
 
 	test("handles numeric exceptions correctly", async () => {
-		// Create a spy for json method
 		const jsonMock = vi.fn((data) => data);
-
-		// Create context object
-		// biome-ignore lint/suspicious/noExplicitAny: We need flexibility for testing
-		const ctx: any = {
+		const ctx = {
 			path: "/sign-in",
 			context: {
 				newSession: {
@@ -281,24 +204,16 @@ describe("auth.hooks.after error handling", () => {
 				},
 			},
 			json: jsonMock,
-		};
-
-		// Force db.select to throw a number instead of an Error object
+		} as MiddlewareInputContext<MiddlewareOptions>;
 		vi.mocked(db.select).mockImplementationOnce(() => {
 			throw 404;
 		});
-
-		// Execute the handler and check result
 		const result = await auth.options.hooks.after(ctx);
-
-		// Verify console.error was called
 		expect(consoleErrorSpy).toHaveBeenCalled();
-
-		// Verify the error response format - for non-Error objects, it will be "Unknown error"
 		expect(result).toEqual({
 			statusCode: "10001",
 			message: "Failure",
-			error: "Unknown error", // Updated to match actual implementation
+			error: "Unknown error",
 		});
 	});
 });