Skip to content

Fix GitHub Actions PR Test Application error messages #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palisadoes opened this issue Feb 17, 2025 · 10 comments
Open

Fix GitHub Actions PR Test Application error messages #3692

palisadoes opened this issue Feb 17, 2025 · 10 comments
Labels
bug Something isn't working test Testing application

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. Our PR testing generated many repeated warning and deprecation messages.
  2. These need to be fixed
  3. Most of the errors contain the text:
    This typically indicates a configuration error in your mocks setup, usually due to a typo or mismatched variable.
    
    OR
    
    React Router Future Flag Warning: React Router will begin wrapping state updates in `React.startTransition` in v7. You can use the `v7_startTransition` future flag to opt-in early. For more information, see https://reactrouter.com/v6/upgrading/future#v7_starttransition.
    
    OR
    
    https://go.apollo.dev/c
    
  4. The substitution of firstName and lastName with name, seems to be a major source of the misalignment
  5. These messages occur whether or not the test suite passes or fails

NOTE: Remove any unnecessary console.log messages as part of this issue

To Reproduce
Steps to reproduce the behavior:

  1. Submit a PR
  2. Observe the errors when you click the link to PR Workflow / Test Application (pull_request)

This is a sample set of messages:

Expected behavior

  • No messages at all

Actual behavior
Look at the output of this representative link

Screenshots

Image

Attachments

This is a sample set of messages:

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Feb 17, 2025
@github-actions github-actions bot added test Testing application unapproved labels Feb 17, 2025
@Faisalmajeed123
Copy link

please assign me.

@Faisalmajeed123
Copy link

Please unassign me from this issue.

@palisadoes
Copy link
Contributor Author

What was the difficulty you faced?

@yugal07
Copy link

yugal07 commented Feb 22, 2025

I will take on this @palisadoes

@Faisalmajeed123
Copy link

Nothing but Currently, I want to focus on learning testing and improving my skills in writing efficient test cases. By unassigning myself, someone else can take on the issue, saving time and effort for both parties.

@yugal07
Copy link

yugal07 commented Mar 8, 2025

Still working on this. Some errors still persists, will tackle them and raise PR shortly

@yugal07
Copy link

yugal07 commented Mar 11, 2025

Hello @palisadoes, I have fixed the react router warnings, and removed the unnecessary console.log statements. The apollo errors are caused due to mismatch between queries expected and mocks. This is in many files, and needs to be opened as separate issues, under this parent issue. should i proceed with the PR that fixes rest of the errors, and raise all the issues? PTAL

@palisadoes
Copy link
Contributor Author

palisadoes commented Mar 11, 2025

Do them all in one PR. We have enough to review already

@arkajyotiadhikary
Copy link

If need help I can hop into this.

@palisadoes
Copy link
Contributor Author

unassigned. Inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Testing application
Projects
Status: Backlog
Development

No branches or pull requests

4 participants