Skip to content

NoMongo: Postgres Migration Support for Venues in orgDashboard #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gautam-divyanshu opened this issue Feb 7, 2025 · 24 comments
Open
Labels
feature request MVP Needed for our 2025 MVP refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@gautam-divyanshu
Copy link
Member

Is your feature request related to a problem? Please describe.
Update query and mutations according to the recently migrated develop-postgres branch of talawa-api.

Describe the solution you'd like
Make the schema support the changes

Additional context

Image

Expected:

Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@amaan-aly246
Copy link
Contributor

@gautam-divyanshu @palisadoes Please assign this issue.
Thanks

@palisadoes palisadoes added GSoC Priority ui/ux issue related and being worked with the figma file of the Admin UI labels Feb 10, 2025
@palisadoes
Copy link
Contributor

This issue aims to restore functionality to the app after migrating to a PostgreSQL API back end.

  1. This is a high priority issue. It's a prerequisite for our GSoC ideas.
  2. The develop branches of Talawa Admin and Talawa API work together. Use those branches to determine the expected behavior of the apps.
  3. Compare the operation of Talawa Admin and Talawa API running together in the develop-postgres branch.
  4. Submit your PR against the develop-postgres branch and attach a video.

@NishantSinghhhhh
Copy link
Contributor

May I work on this issue if no pull request has been submitted in the last two days?

@amaan-aly246
Copy link
Contributor

@NishantSinghhhhh I'm working on this. It's just I was doing some other issue.

@amaan-aly246
Copy link
Contributor

@palisadoes venuesTable does not have column for capacity but in frontend venues capacity is used so should I omit capacity property from the talawa-admin or add capacity column to the venuesTable ?

@palisadoes
Copy link
Contributor

Add capacity to the API

@amaan-aly246
Copy link
Contributor

@palisadoes updateVenue does not take attachments as argument but createVenue does. Is this intentional ? If it is so should I remove the option of adding attachments from the frontend as well when the user is updating the venue ?

@amaan-aly246
Copy link
Contributor

nevermind just checked develop branch of talawa-api , it has upload option. I'll update the backend then.

@amaan-aly246
Copy link
Contributor

@palisadoes Do I have to update the test files of Venue component since Venue component has been updated because of the migration before raising the PR or is it a separate issue ?

@palisadoes
Copy link
Contributor

All in one PR. We have enough to review.

@amaan-aly246
Copy link
Contributor

@palisadoes . I'm able to do rest of the necessary things but when I try to create venues with attachments of type [Upload!] I get an error : "Variable \"$attachments\" got invalid value {} at \"attachments[0]\"; Upload value invalid." . How should I create type Upload in frontend ?

Image
Image

@palisadoes
Copy link
Contributor

Please use your initiative and propose a solution that will stand the test of time. Evaluate why it is better than other commonly used alternatives.

@NishantSinghhhhh
Copy link
Contributor

@palisadoes Sir I am about to complete my current issue (All functionalities have been restored in action Item will be adding tests now ) , so if possible could you assign this issue to me I will be more than happy to work on this one

@mpdesai90
Copy link

@NishantSinghhhhh If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@NishantSinghhhhh
Copy link
Contributor

NishantSinghhhhh commented Mar 7, 2025

@amaan-aly246 are you still working on this issue , if you need any help do let me know , I will be happy to help you

@Cioppolo14
Copy link
Contributor

@amaan-aly246 Please let us know you are still working on this issue.

@amaan-aly246
Copy link
Contributor

amaan-aly246 commented Mar 8, 2025

@Cioppolo14 I was busy with my exams (I mentioned this in Slack to peter) and will start working on this now. I’ll raise a PR shortly.

@amaan-aly246
Copy link
Contributor

amaan-aly246 commented Mar 10, 2025

@palisadoes I have created a PR in talawa-api (3352) for the changes I made to address this issue.

@palisadoes
Copy link
Contributor

Unassigning. Inactivity.

@iamanishx
Copy link

@palisadoes can i take this as am wrorking related to this ?

@Doraemon012
Copy link
Member

@palisadoes I would like to work on this, please assign this to me.

@Bittukr7479
Copy link

@palisadoes I want to work on this issue, please assign me.

@Doraemon012
Copy link
Member

Doraemon012 commented Apr 18, 2025

@palisadoes I apologize for the delay. The work is in progress, I’ll raise the PR soon.

@palisadoes
Copy link
Contributor

Unassigning. Inactivity

@palisadoes palisadoes added MVP Needed for our 2025 MVP and removed GSoC Priority MVP Needed for our 2025 MVP labels May 18, 2025
@palisadoes palisadoes added MVP Needed for our 2025 MVP and removed MVP Needed for our 2025 MVP labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request MVP Needed for our 2025 MVP refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Backlog
Status: Backlog
Status: Backlog
Status: Backlog
Development

No branches or pull requests

9 participants