Skip to content

Commit 38d1286

Browse files
committed
fixed tests
1 parent 4e3bda8 commit 38d1286

File tree

3 files changed

+36
-24
lines changed

3 files changed

+36
-24
lines changed

src/screens/OrgList/OrgList.test.tsx

Lines changed: 34 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ async function wait(ms = 100): Promise<void> {
4444
afterEach(() => {
4545
localStorage.clear();
4646
cleanup();
47+
jest.clearAllMocks();
4748
});
4849

4950
describe('Organisations Page testing as SuperAdmin', () => {
5051
setItem('id', '123');
51-
5252
const link = new StaticMockLink(MOCKS, true);
5353
const link2 = new StaticMockLink(MOCKS_EMPTY, true);
5454
const link3 = new StaticMockLink(MOCKS_WITH_ERROR, true);
@@ -475,7 +475,6 @@ describe('Organisations Page testing as SuperAdmin', () => {
475475

476476
describe('Organisations Page testing as Admin', () => {
477477
const link = new StaticMockLink(MOCKS_ADMIN, true);
478-
479478
test('Create organization modal should not be present in the page for Admin', async () => {
480479
setItem('id', '123');
481480
setItem('SuperAdmin', false);
@@ -501,35 +500,47 @@ describe('Organisations Page testing as Admin', () => {
501500
setItem('SuperAdmin', false);
502501
setItem('AdminFor', [{ name: 'adi', _id: 'a0', image: '' }]);
503502

504-
await act(async () => {
505-
render(
506-
<MockedProvider addTypename={false} link={link}>
507-
<BrowserRouter>
508-
<Provider store={store}>
509-
<I18nextProvider i18n={i18nForTest}>
510-
<OrgList />
511-
</I18nextProvider>
512-
</Provider>
513-
</BrowserRouter>
514-
</MockedProvider>,
515-
);
516-
517-
await wait();
518-
});
519-
const sortDropdown = await waitFor(() => screen.getByTestId('sort'));
503+
render(
504+
<MockedProvider addTypename={false} link={link}>
505+
<BrowserRouter>
506+
<Provider store={store}>
507+
<I18nextProvider i18n={i18nForTest}>
508+
<OrgList />
509+
</I18nextProvider>
510+
</Provider>
511+
</BrowserRouter>
512+
</MockedProvider>,
513+
);
514+
515+
await wait();
516+
517+
const sortDropdown = screen.getByTestId('sort');
520518
expect(sortDropdown).toBeInTheDocument();
521519

522520
const sortToggle = screen.getByTestId('sortOrgs');
523521

524-
fireEvent.click(sortToggle);
525-
const latestOption = await waitFor(() => screen.getByTestId('latest'));
522+
await act(async () => {
523+
fireEvent.click(sortToggle);
524+
});
525+
526+
const latestOption = screen.getByTestId('latest');
526527

527-
fireEvent.click(latestOption);
528+
await act(async () => {
529+
fireEvent.click(latestOption);
530+
});
528531

529532
expect(sortDropdown).toBeInTheDocument();
530-
fireEvent.click(sortToggle);
533+
534+
await act(async () => {
535+
fireEvent.click(sortToggle);
536+
});
537+
531538
const oldestOption = await waitFor(() => screen.getByTestId('oldest'));
532-
fireEvent.click(oldestOption);
539+
540+
await act(async () => {
541+
fireEvent.click(oldestOption);
542+
});
543+
533544
expect(sortDropdown).toBeInTheDocument();
534545
});
535546
});

src/screens/OrgList/OrgList.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ function orgList(): JSX.Element {
233233
};
234234

235235
if (errorList || errorUser) {
236+
errorHandler(t, errorList || errorUser);
236237
localStorage.clear();
237238
window.location.assign('/');
238239
}

src/screens/OrgList/OrganizationModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ const OrganizationModal: React.FC<InterfaceOrganizationModalProps> = ({
301301
<hr />
302302
<span className={styles.orText}>{tCommon('OR')}</span>
303303
</div>
304-
{(adminFor.length > 0 || superAdmin) && (
304+
{((adminFor && adminFor.length > 0) || superAdmin) && (
305305
<div className={styles.sampleOrgSection}>
306306
<Button
307307
className={styles.sampleOrgCreationBtn}

0 commit comments

Comments
 (0)