Merge pull request #169 from abhijeetw035/bugfix/issue-56

fix: update GitHub Actions with correct Node.js, submodules, and working CI build

Author: drtechie

.github/workflows/build-on-pull-request.yml

@@ -8,25 +8,27 @@ jobs:
   Build:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
+      - name: Checkout code with submodule
+        uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.head.ref }}
           repository: ${{ github.event.pull_request.head.repo.full_name }}
           submodules: true
           fetch-depth: 0 
 
       - name: Update submodules
-        run: git submodule update --init --recursive
+        run: |
+          git submodule init
+          git submodule update --recursive
 
       - name: Setup JDK 17
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v4
         with:
           java-version: 17
           distribution: 'adopt'
 
       - name: Set up Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 
@@ -35,7 +37,5 @@ jobs:
           npm config set legacy-peer-deps true
           npm install -g @angular/cli
           npm install [email protected] --save-dev
-          npm install [email protected]
-          npm install node-sass
           npm install --force
-          npm run build
+          npm run build-ci

.github/workflows/codeql.yml

@@ -52,7 +52,7 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3
+      uses: github/codeql-action/init@v4
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -66,7 +66,7 @@ jobs:
     # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v3
+      uses: github/codeql-action/autobuild@v4
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -79,6 +79,6 @@ jobs:
     #     ./location_of_script_within_repo/buildscript.sh
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3
+      uses: github/codeql-action/analyze@v4
       with:
         category: "/language:${{matrix.language}}"

.github/workflows/package-prod.yml

@@ -16,18 +16,18 @@ jobs:
     steps:
 
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
 
     - name: Set up Java
-      uses: actions/setup-java@v3
+      uses: actions/setup-java@v4
       with:
           java-version: '17'
           distribution: 'adopt'
 
 
     - name: Set up Node.js
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v4
       with:
           node-version: 18
 
@@ -38,14 +38,12 @@ jobs:
             npm install -g @angular/cli
             npm install -g grunt-cli
             npm install [email protected] --save-dev
-            npm install [email protected]
-            npm install node-sass --force
             npm install --force
             ng build --configuration production
             
             
     - name: Upload WAR file as artifact
-      uses: actions/upload-artifact@v2 
+      uses: actions/upload-artifact@v4
       with:
         name: MMU-UI
         path: dist/mmu-ui/mmu-ui.war

.github/workflows/package.yml

@@ -17,7 +17,7 @@ jobs:
     steps:
 
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         submodules: true  # Include submodules
         fetch-depth: 0    # Ensure the full history is fetched
@@ -26,13 +26,13 @@ jobs:
       run: git submodule update --init --recursive
 
     - name: Set up Java
-      uses: actions/setup-java@v3
+      uses: actions/setup-java@v4
       with:
         java-version: '17'
         distribution: 'adopt'
 
     - name: Set up Node.js
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v4
       with:
         node-version: 18      
 
@@ -41,16 +41,14 @@ jobs:
         npm config set legacy-peer-deps true
         npm install -g @angular/cli
         npm install [email protected] --save-dev
-        npm install [email protected]
-        npm install node-sass
         npm install --force
         npm run build
         
     - name: Create WAR file 
       run: jar -cvf mmu-ui.war -C dist .
 
     - name: Upload WAR file as artifact
-      uses: actions/upload-artifact@v2 
+      uses: actions/upload-artifact@v4 
       with:
         name: MMU-UI
         path: mmu-ui.war 

.gitignore

@@ -42,4 +42,5 @@ testem.log
 .DS_Store
 Thumbs.db
 
-src/environments/environment.ts
+src/environments/environment.ts
+src/environments/environment.ci.ts

Common-UI

@@ -50,15 +50,27 @@
                 }
               ],
               "outputHashing": "all",
-              "optimization": true
+              "optimization": true,
+              "fileReplacements": [
+                {
+                  "replace": "src/environments/environment.ts",
+                  "with": "src/environments/environment.prod.ts"
+                }
+              ]
             },
             "development": {
               "buildOptimizer": false,
               "optimization": false,
               "vendorChunk": true,
               "extractLicenses": false,
               "sourceMap": true,
-              "namedChunks": true
+              "namedChunks": true,
+              "fileReplacements": [
+                {
+                  "replace": "src/environments/environment.ts",
+                  "with": "src/environments/environment.local.ts"
+                }
+              ]
             },
             "ci": {
               "budgets": [