Skip to content

Commit e4d7efd

Browse files
committed
fix comments
1 parent cd6e89f commit e4d7efd

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

internal/cacct/cacct.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ func QueryJob() util.CraneCmdError {
243243
taskInfo.Name,
244244
taskInfo.Partition,
245245
taskInfo.Account,
246-
strconv.FormatFloat(taskInfo.AllocatedResView.AllocatableRes.CpuCoreLimit, 'f', 2, 64),
246+
ProcessAllocCPUs(taskInfo),
247247
taskInfo.Status.String(),
248248
exitCode}
249249
}
@@ -413,7 +413,7 @@ func ProcessReqMemPerNode(task *protos.TaskInfo) string {
413413
// AllocMemPerNode (m)
414414
func ProcessAllocMemPerNode(task *protos.TaskInfo) string {
415415
if task.NodeNum == 0 {
416-
return "0M"
416+
return "0"
417417
}
418418
allocMemPerNode := task.AllocatedResView.AllocatableRes.MemoryLimitBytes / uint64(task.NodeNum)
419419
return util.FormatMemToMB(allocMemPerNode)

internal/ccontrol/ccontrol.go

+15-9
Original file line numberDiff line numberDiff line change
@@ -414,10 +414,7 @@ func ShowJobs(jobIds string, queryAll bool) util.CraneCmdError {
414414
"\tStartTime=%v EndTime=%v Partition=%v NodeList=%v ExecutionHost=%v\n"+
415415
"\tCmdLine=\"%v\" Workdir=%v\n"+
416416
"\tPriority=%v Qos=%v CpusPerTask=%v MemPerNode=%v\n"+
417-
"\tReqRes=node=%d cpu=%.2f mem=%v gres=%s\n"+
418-
"\tAllocRes=node=%d cpu=%.2f mem=%v gres=%s\n"+
419-
"\tReqNodeList=%v ExecludeNodeList=%v\n"+
420-
"\tExclusive=%v Comment=%v\n",
417+
"\tReqRes=node=%d cpu=%.2f mem=%v gres=%s\n",
421418
taskInfo.TaskId, taskInfo.Name, craneUser.Username, taskInfo.Uid, group.Name, taskInfo.Gid,
422419
taskInfo.Account, taskInfo.Status.String(), runTimeStr, timeLimitStr, timeSubmitStr,
423420
timeStartStr, timeEndStr, taskInfo.Partition, formatHostNameStr(taskInfo.GetCranedList()),
@@ -428,13 +425,22 @@ func ShowJobs(jobIds string, queryAll bool) util.CraneCmdError {
428425
taskInfo.NodeNum, taskInfo.ReqResView.AllocatableRes.CpuCoreLimit*float64(taskInfo.NodeNum),
429426
util.FormatMemToMB(taskInfo.ReqResView.AllocatableRes.MemoryLimitBytes*uint64(taskInfo.NodeNum)),
430427
formatDeviceMap(taskInfo.ReqResView.DeviceMap),
431-
taskInfo.NodeNum, taskInfo.AllocatedResView.AllocatableRes.CpuCoreLimit,
428+
)
429+
430+
if taskInfo.Status == protos.TaskStatus_Running {
431+
fmt.Printf("\tAllocRes=node=%d cpu=%.2f mem=%v gres=%s\n",
432+
taskInfo.NodeNum,
433+
taskInfo.AllocatedResView.AllocatableRes.CpuCoreLimit,
432434
util.FormatMemToMB(taskInfo.AllocatedResView.AllocatableRes.MemoryLimitBytes),
433435
formatDeviceMap(taskInfo.AllocatedResView.DeviceMap),
434-
formatHostNameStr(util.HostNameListToStr(taskInfo.GetReqNodes())),
435-
formatHostNameStr(util.HostNameListToStr(taskInfo.GetExcludeNodes())),
436-
strconv.FormatBool(taskInfo.Exclusive), formatJobComment(taskInfo.ExtraAttr),
437-
)
436+
)
437+
}
438+
439+
fmt.Printf("\tReqNodeList=%v ExecludeNodeList=%v\n"+
440+
"\tExclusive=%v Comment=%v\n",
441+
formatHostNameStr(util.HostNameListToStr(taskInfo.GetReqNodes())),
442+
formatHostNameStr(util.HostNameListToStr(taskInfo.GetExcludeNodes())),
443+
strconv.FormatBool(taskInfo.Exclusive), formatJobComment(taskInfo.ExtraAttr))
438444
}
439445

440446
// If any job is requested but not returned, remind the user

internal/cqueue/cqueue.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ func ProcessNodeList(task *protos.TaskInfo) string {
349349
// 'm' group
350350
func ProcessAllocMemPerNode(task *protos.TaskInfo) string {
351351
if task.NodeNum == 0 {
352-
return "0M"
352+
return "0"
353353
}
354354
return util.FormatMemToMB(task.AllocatedResView.AllocatableRes.MemoryLimitBytes /
355355
uint64(task.NodeNum))

0 commit comments

Comments
 (0)