Skip to content

Commit 88f9ffa

Browse files
committed
fix bug
1 parent f066559 commit 88f9ffa

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

internal/cacct/cacct.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,8 @@ func ProcessReqMemPerNode(task *protos.TaskInfo) string {
412412

413413
// AllocMemPerNode (m)
414414
func ProcessAllocMemPerNode(task *protos.TaskInfo) string {
415-
if task.ReqResView.AllocatableRes == nil {
416-
return "unkown"
415+
if task.NodeNum == 0 {
416+
return "0"
417417
}
418418
return strconv.FormatUint(task.AllocMemTotal / uint64(task.NodeNum) /(1024*1024), 10)
419419
}

internal/ccontrol/ccontrol.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,9 @@ func ShowJobs(jobIds string, queryAll bool) util.CraneCmdError {
359359
formatHostNameStr(util.HostNameListToStr(taskInfo.GetExecutionNode())),
360360
taskInfo.CmdLine, taskInfo.Cwd,
361361
taskInfo.Priority, taskInfo.Qos, taskInfo.ReqResView.AllocatableRes.CpuCoreLimit, util.FormatMemToMB(taskInfo.ReqResView.AllocatableRes.MemoryLimitBytes),
362-
taskInfo.NodeNum, taskInfo.ReqResView.AllocatableRes.CpuCoreLimit*float64(taskInfo.NodeNum), formatDeviceMap(taskInfo.ReqResView.DeviceMap),
362+
taskInfo.NodeNum, taskInfo.ReqResView.AllocatableRes.CpuCoreLimit*float64(taskInfo.NodeNum),
363+
util.FormatMemToMB(taskInfo.ReqResView.AllocatableRes.MemoryLimitBytes*uint64(taskInfo.NodeNum)),
364+
formatDeviceMap(taskInfo.ReqResView.DeviceMap),
363365
taskInfo.NodeNum, taskInfo.AllocCpusTotal, util.FormatMemToMB(taskInfo.AllocMemTotal), taskInfo.AllocDeviceTotal,
364366
formatHostNameStr(util.HostNameListToStr(taskInfo.GetReqNodes())), formatHostNameStr(util.HostNameListToStr(taskInfo.GetExcludeNodes())),
365367
formatJobComment(taskInfo.ExtraAttr), strconv.FormatBool(taskInfo.Exclusive),

internal/ceff/ceff.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,12 @@ func PrintTaskInfo(taskInfo *protos.TaskInfo, records []*ResourceUsageRecord) er
361361

362362
// Calculate mem efficiency
363363
memEfficiency := 0.0
364-
mallocMemMbPerNode := float64(taskInfo.AllocMemTotal) / float64(taskInfo.NodeNum) / (1024 * 1024)
364+
mallocMemMbPerNode := 0.0
365+
if taskInfo.NodeNum == 0 {
366+
return fmt.Errorf("Node num empty")
367+
} else {
368+
mallocMemMbPerNode = float64(taskInfo.AllocMemTotal) / float64(taskInfo.NodeNum) / (1024 * 1024)
369+
}
365370
totalMallocMemMb := float64(taskInfo.AllocMemTotal)
366371
if totalMallocMemMb != 0 {
367372
memEfficiency = totalMemMb / totalMallocMemMb * 100

internal/cqueue/cqueue.go

+3
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,9 @@ func ProcessNodeList(task *protos.TaskInfo) string {
348348

349349
// 'm' group
350350
func ProcessAllocMemPerNode(task *protos.TaskInfo) string {
351+
if task.NodeNum == 0 {
352+
return "0"
353+
}
351354
return strconv.FormatUint(task.AllocMemTotal / uint64(task.NodeNum) / (1024*1024) , 10)
352355
}
353356

0 commit comments

Comments
 (0)