[Refactor] Remove CWalletDBWrapper::GetUpdateCounter()

Author: random-zebra

src/wallet/db.cpp

@@ -433,11 +433,6 @@ void CWalletDBWrapper::IncrementUpdateCounter()
     ++nUpdateCounter;
 }
 
-unsigned int CWalletDBWrapper::GetUpdateCounter()
-{
-    return nUpdateCounter.load();
-}
-
 void CDB::Close()
 {
     if (!pdb)

src/wallet/walletdb.cpp

@@ -797,24 +797,22 @@ void MaybeCompactWalletDB()
         return;
     }
 
-    /* TODO: fix me
-    CWalletDBWrapper& dbh = pwalletMain->GetDBHandle();
+    for (CWalletRef pwallet : vpwallets) {
+        CWalletDBWrapper& dbh = pwallet->GetDBHandle();
 
-    static unsigned int nLastSeen = dbh.GetUpdateCounter();
-    static unsigned int nLastFlushed = dbh.GetUpdateCounter();
-    static int64_t nLastWalletUpdate = GetTime();
-
-    if (nLastSeen != dbh.GetUpdateCounter()) {
-        nLastSeen = dbh.GetUpdateCounter();
-        nLastWalletUpdate = GetTime();
-    }
+        unsigned int nUpdateCounter = dbh.nUpdateCounter;
+        if (dbh.nLastSeen != nUpdateCounter) {
+            dbh.nLastSeen = nUpdateCounter;
+            dbh.nLastWalletUpdate = GetTime();
+        }
 
-    if (nLastFlushed != dbh.GetUpdateCounter() && GetTime() - nLastWalletUpdate >= 2) {
-        if (CDB::PeriodicFlush(dbh)) {
-            nLastFlushed = dbh.GetUpdateCounter();
+        if (dbh.nLastFlushed != nUpdateCounter && GetTime() - dbh.nLastWalletUpdate >= 2) {
+            if (CDB::PeriodicFlush(dbh)) {
+                dbh.nLastFlushed = nUpdateCounter;
+            }
         }
     }
-    */
+
     fOneThread = false;
 }