test: Add test for -debuglogfile

backports bitcoin/bitcoin@2323242

Author: random-zebra

test/functional/feature_logging.py

@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+# Copyright (c) 2017 The Bitcoin Core developers
+# Copyright (c) 20200 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+"""Test debug logging."""
+
+import os
+
+from test_framework.test_framework import PivxTestFramework
+
+class LoggingTest(PivxTestFramework):
+    def set_test_params(self):
+        self.num_nodes = 1
+        self.setup_clean_chain = True
+
+    def run_test(self):
+        # test default log file name
+        assert os.path.isfile(os.path.join(self.nodes[0].datadir, "regtest", "debug.log"))
+        self.log.info("Default filename ok")
+
+        # test alternative log file name in datadir
+        self.restart_node(0, ["-debuglogfile=foo.log"])
+        assert os.path.isfile(os.path.join(self.nodes[0].datadir, "regtest", "foo.log"))
+        self.log.info("Alternative filename ok")
+
+        # test alternative log file name outside datadir
+        tempname = os.path.join(self.options.tmpdir, "foo.log")
+        self.restart_node(0, ["-debuglogfile=%s" % tempname])
+        assert os.path.isfile(tempname)
+        self.log.info("Alternative filename outside datadir ok")
+
+        # check that invalid log (relative) will cause error
+        self.stop_node(0)
+        self.assert_start_raises_init_error(0, ["-debuglogfile=ssdksjdf/sdasdfa/sdfsdfsfd"],
+                                                "Error: Could not open debug log file")
+        self.log.info("Invalid relative filename throws")
+
+        # check that invalid log (absolute) will cause error
+        self.stop_node(0)
+        invalidname = os.path.join(self.options.tmpdir, "foo/foo.log")
+        self.assert_start_raises_init_error(0, ["-debuglogfile=%s" % invalidname],
+                                               "Error: Could not open debug log file")
+        self.log.info("Invalid absolute filename throws")
+
+
+if __name__ == '__main__':
+    LoggingTest().main()

test/functional/test_runner.py

@@ -69,6 +69,7 @@
     'rpc_rawtransaction.py',                    # ~ 193 sec
     'wallet_zapwallettxes.py',                  # ~ 180 sec
     'wallet_keypool_topup.py',                  # ~ 174 sec
+    'feature_logging.py',                       # ~ 166 sec
     'wallet_txn_doublespend.py --mineblock',    # ~ 157 sec
     'wallet_txn_clone.py --mineblock',          # ~ 157 sec
     'rpc_spork.py',                             # ~ 156 sec
@@ -153,6 +154,7 @@
 LEGACY_SKIP_TESTS = [
     # These tests are not run when the flag --legacywallet is used
     'feature_help.py',
+    'feature_logging.py',
     'feature_reindex.py',
     'feature_proxy.py',
     'feature_uacomment.py',