Unexpected Error on Application Startup: "An item with the same key has already been added. Key: 41"

[intellimedhu]

I'm getting an ArgumentException when starting the webapp:

ArgumentException: An item with the same key has already been added. Key: 41

Details

• The error only occurs when the webapp starts, runs correctly after a page reload.
• 41 is the ID of the SiteSettings record in the database.
• Version: 2.1.5 with .NET 8
• The issue does not occur in my other applications, even though the same configuration used.

Stack:

System.ArgumentException: An item with the same key has already been added. Key: 41
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at YesSql.Indexes.IdentityMap.AddEntity(Int64 id, Object entity)
   at YesSql.Session.Get[T](IList`1 documents, String collection)
   at YesSql.Services.DefaultQuery.Query`1.FirstOrDefaultImpl()
   at YesSql.Services.DefaultQuery.Query`1.FirstOrDefaultImpl()
   at OrchardCore.Data.Documents.DocumentStore.GetOrCreateImmutableAsync[T](Func`1 factoryAsync)
   at OrchardCore.Documents.DocumentManager`1.GetOrCreateImmutableAsync(Func`1 factoryAsync)
   at OrchardCore.Settings.Services.SiteService.GetSiteSettingsAsync()
   at OrchardCore.Settings.SiteServiceExtensions.GetSettingsAsync[T](ISiteService siteService)
   at OrchardCore.Media.Processing.MediaTokenSettingsUpdater.ActivatedAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.<>c.<<ActivateShellInternalAsync>b__43_0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

Has anyone encountered a similar issue, or does anyone have suggestions for investigating the root cause?

[Piedone]

I'm just spitballing here, but perhaps you have a duplicate document with the Type column OrchardCore.Settings.SiteSettings, OrchardCore.Settings in the Document table? That would be a bug.

[intellimedhu]

Unfortunately, it's not about duplicate records. There is no duplication in the database. I suspect the record is being loaded twice into the IdentityMap for some reason.
I'm sure I'm making a mistake somewhere, but after a long debugging, I can't figure out what it is.

[Piedone]

@sebastienros any hints, perhaps?

[intellimedhu]

I found the root cause of the issue.

The problem occurs because I am running the RolesStep recipe during setup. The difference between my two applications is in how the roles are defined:

In one application:

{
  "name": "Roles",
  "Roles": [
    {
      "Name": "Administrator",
      "Description": "Administrator role",
      "Permissions": []
    }
  ]
}

In the other application:

{
  "name": "Roles",
  "Roles": [
    {
      "Name": "Administrator",
      "Description": "Administrator role",
      "Permissions": []
    },
    {
      "Name": "Director",
      "Description": "Director role",
      "Permissions": []
    }
  ]
}

If I try to add only the Administrator role, the issue appears. However, if the role is not of type system role, or if there is at least one other non-system role in the list, the issue does not occur.

I understand that it doesn’t make much sense to create only an Administrator role on its own, but I still shouldn’t be getting this error.

[Piedone]

Well, that's interesting, thanks for sharing. Does this also happen if you just create the Director role? So, a role (or roles) that are not system roles?

BTW creating system roles won't be necessary with v3: #17271.

[sebastienros]

This is something we have isolated in another place and fixed in the main branch.
If you used the latest version of SQL the exception would be this instead, as it would detect the wrong usage pattern:

throw new InvalidOperationException("An object with the same identity is already part of this transaction. Reload it before doing any changes on it.");

What it means, and based on your repro, is that the Settings document is "saved" with SaveChangesAsync twice and gets modified in-between. Probably due to the DocumentManager. I believe it's a bug in OC.

[sebastienros]

c.f. #17084

[Piedone]

Thanks!