Fix intermittent redirects during external auto-login (#17220)

MikeAlhayek · web-flow · commit 87a21fe3e74b · 2024-12-12T09:01:31.000-08:00
diff --git a/src/OrchardCore.Modules/OrchardCore.Users/Services/ExternalLoginFormEvents.cs b/src/OrchardCore.Modules/OrchardCore.Users/Services/ExternalLoginFormEvents.cs
@@ -35,6 +35,14 @@ public ExternalLoginFormEvents(
         _httpContextAccessor = httpContextAccessor;
     }
 
+    public override Task LoggedInAsync(IUser user)
+    {
+        var tempData = _tempDataDictionaryFactory.GetTempData(_httpContextAccessor.HttpContext);
+        tempData.Remove(ExternalLoginAutoRedirectKeyName);
+
+        return Task.CompletedTask;
+    }
+
     public override async Task<IActionResult> LoggingInAsync()
     {
         if (!_externalLoginOptions.UseExternalProviderIfOnlyOneDefined)

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,14 @@ public ExternalLoginFormEvents(`
`35`	`35`	`_httpContextAccessor = httpContextAccessor;`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ public override Task LoggedInAsync(IUser user)`
	`39`	`+ {`
	`40`	`+ var tempData = _tempDataDictionaryFactory.GetTempData(_httpContextAccessor.HttpContext);`
	`41`	`+ tempData.Remove(ExternalLoginAutoRedirectKeyName);`
	`42`	`+`
	`43`	`+ return Task.CompletedTask;`
	`44`	`+ }`
	`45`	`+`
`38`	`46`	`public override async Task<IActionResult> LoggingInAsync()`
`39`	`47`	`{`
`40`	`48`	`if (!_externalLoginOptions.UseExternalProviderIfOnlyOneDefined)`