Skip to content

Commit 2a27ce0

Browse files
committed
review: update with patch proposition
1 parent 1574b8b commit 2a27ce0

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2828

2929
### Fixed
3030

31+
- [Library] Remove extra padding in ControlItem ([#572](https://github.com/Orange-OpenSource/ouds-ios/issues/572))
3132
- [Library] Add accessibility label to vocalize the IconOnly button style ([#460](https://github.com/Orange-OpenSource/ouds-ios/issues/460))
3233
- [Library] Chevron for link component pointing to bad direction in RTL mode ([#557](https://github.com/Orange-OpenSource/ouds-ios/issues/557))
3334
- [Library] Remove divider if outline effect is active in RadioItem component ([#564](https://github.com/Orange-OpenSource/ouds-ios/issues/564))
3435
- [DesignToolbox] In RTL mode code sample text not aligned on the left ([#554](https://github.com/Orange-OpenSource/ouds-ios/issues/554))
35-
- [Library] Remove extra pudding in ControlItem ([#572](https://github.com/Orange-OpenSource/ouds-ios/issues/572))
3636
- [Library] Adjust vertical alignment of text labels according to their height in ContolItem ([#55](https://github.com/Orange-OpenSource/ouds-ios/issues/550))
3737
- [DesignToolbox] In RTL mode code sample text not aligned on the left ([#554](https://github.com/Orange-OpenSource/ouds-ios/issues/554))
3838
- [DesignToolbox] Chevron for navigation link pointing to bad direction in RTL mode ([#553](https://github.com/Orange-OpenSource/ouds-ios/issues/553))

OUDS/Core/Components/Sources/Checkbox/Internal/CheckboxIndicator.swift

+4-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ struct CheckboxIndicator: View {
3232
// MARK: - Body
3333

3434
var body: some View {
35-
indicator().modifier(CheckboxIndicatorModifier(interactionState: interactionState, indicatorState: indicatorState, isError: isError))
35+
indicator()
36+
.modifier(CheckboxIndicatorModifier(interactionState: interactionState,
37+
indicatorState: indicatorState,
38+
isError: isError))
3639
}
3740

3841
// MARK: - Indicator

OUDS/Core/Components/Sources/Internal/ControlItem/ControlItemContent.swift

+3-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ struct ControlItemContent: View {
6565
private func labelContainer() -> some View {
6666
ControlItemLabel(interactionState: interactionState, layoutData: layoutData)
6767
.readSize { size in
68-
verticalAlignment = size.height > theme.controlItem.controlItemSizeMaxHeightAssetsContainer ? .top : .center
68+
Task { @MainActor in
69+
verticalAlignment = size.height > theme.controlItem.controlItemSizeMaxHeightAssetsContainer ? .top : .center
70+
}
6971
}
7072
}
7173

OUDS/Core/Components/Sources/Internal/View+readSize.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extension View {
2727
///
2828
/// - Parameter onChange: Called when the size changes
2929
@MainActor
30-
func readSize(onChange: @escaping (CGSize) -> Void) -> some View {
30+
func readSize(onChange: @Sendable @escaping (CGSize) -> Void) -> some View {
3131
background(
3232
GeometryReader { geometryProxy in
3333
Color.clear

OUDS/Core/Components/Sources/Radio/Internal/RadioIndicator.swift

+4-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ struct RadioIndicator: View {
3131
// MARK: - Body
3232

3333
var body: some View {
34-
indicator().modifier(RadioIndicatorModifier(interactionState: interactionState, isOn: isOn, isError: isError))
34+
indicator()
35+
.modifier(RadioIndicatorModifier(interactionState: interactionState,
36+
isOn: isOn,
37+
isError: isError))
3538
}
3639

3740
// MARK: - Indicator

0 commit comments

Comments
 (0)