Skip to content

Animated Title: "Dissolving Text" is not working properly #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobonov opened this issue Apr 5, 2020 · 4 comments · Fixed by #3353
Closed

Animated Title: "Dissolving Text" is not working properly #3350

bobonov opened this issue Apr 5, 2020 · 4 comments · Fixed by #3353
Labels
🐞 bug A bug, error, or breakage of any kind

Comments

@bobonov
Copy link

bobonov commented Apr 5, 2020

Describe the bug:
Using the animated title "Dissolving Text" result in an incomplete animation or probably.
I tried to make a rendering using all defeault values, even for the title and the name
But the result is not correct.
I do not know how this effect should be, but for sure the should not be half title reapparing at the end.

  1. Basicalli it start with the whole title
  2. Then the title start dissolving
  3. When it is almost dissolved the title start to reappear one char per time
  4. The title do not show completely again, it stop after some char

Probably the title should show char by char and then start dissolving, but for sure it should not half show at the end of the animation

Steps to reproduce the behavior:

  1. Go to Anomated Title
  2. Select "dissolving Text" effect
  3. Click on render

Expected behavior:
A proper animated text.

System Details:

  • OpenShot-v2.5.1-dev2-1585970041-166f6938-232f3f79-x86_64
  • Operating System / Distro: Windows 10
  • Blender: 2.82

Screenshots:
Here is a screenshot of the last frame of the animation.
openshot-qt_spauUMrvsP
I attach also the video export
export.zip

@bobonov bobonov added the 🐞 bug A bug, error, or breakage of any kind label Apr 5, 2020
@bobonov bobonov changed the title Animated Title: Animated Title: "Dissolving Text" is not working properly Apr 5, 2020
@pappou99
Copy link

pappou99 commented Apr 5, 2020

I can confirm this also under Ubuntu.
OpenShot version: 2.5.1-dev2
libopenshot: 0.2.5-dev

Could be an error in libopenshot or dissolve.py

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 6, 2020

Yeah, I see it — the error is in the particle system lifetime setting, on line 116 of dissolve.py.

bpy.ops.object.particle_system_add()
# Particle parameters
ActiveObjectText.particle_systems[0].settings.count = NbQuads
ActiveObjectText.particle_systems[0].settings.frame_start = 10
ActiveObjectText.particle_systems[0].settings.frame_end = 60
ActiveObjectText.particle_systems[0].settings.lifetime = 80
ActiveObjectText.particle_systems[0].point_cache.frame_step = 1
ActiveObjectText.particle_systems[0].settings.normal_factor = 0.0

Because the particle system starts affecting particles in frame 10, with a lifetime of 80 some of the earliest particles will start to die off at frame 90, before the 128-frame animation is complete. It appears that, when particles die, they "reset" to their starting point.

The lifetime value should be 120, to ensure that the particle system keeps control of all particles for the entire duration of the animation.

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 6, 2020

I just merged that change, which you can test by downloading the most recent Daily Build from https://openshot.org/download/

@bobonov
Copy link
Author

bobonov commented Apr 7, 2020

Just confirming it works, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug A bug, error, or breakage of any kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants