Fixing Sentry #OPENSHOT-4D: Couldn't apply 'update' to update listener: <windows.models.properties_model.PropertiesModel object at 0x000002407f9bf4c0>. list index out of range. This was mostly caused by "load" UpdateActions, which have an empty list as a key.

Author: jonoomph

src/windows/models/properties_model.py

@@ -70,7 +70,7 @@ class PropertiesModel(updates.UpdateInterface):
     def changed(self, action):
 
         # Handle change
-        if action.key and action.key[0] in ["clips", "effects"] and action.type in ["update", "insert"]:
+        if len(action.key) >= 1 and action.key[0] in ["clips", "effects"] and action.type in ["update", "insert"]:
             log.debug(action.values)
             # Update the model data
             self.update_model(get_app().window.txtPropertyFilter.text())

src/windows/video_widget.py

@@ -52,7 +52,7 @@ class VideoWidget(QWidget, updates.UpdateInterface):
     # This method is invoked by the UpdateManager each time a change happens (i.e UpdateInterface)
     def changed(self, action):
         # Handle change
-        if (action.key and action.key[0] in [
+        if (len(action.key) >= 1 and action.key[0] in [
                 "display_ratio", "pixel_ratio"
                 ] or action.type in ["load"]):
             # Update display ratio (if found)

src/windows/views/timeline.py

@@ -134,7 +134,7 @@ def changed(self, action):
             return
 
         # Bail out if change unrelated to webview
-        if action.key and action.key[0] not in ["clips", "effects", "duration", "layers", "markers"]:
+        if len(action.key) >= 1 and action.key[0] not in ["clips", "effects", "duration", "layers", "markers"]:
             log.debug(f"Skipping unneeded webview update for '{action.key[0]}'")
             return
 

src/windows/views/timeline_backend/qwidget.py

@@ -122,6 +122,10 @@ def get_html(self):
 
     # This method is invoked by the UpdateManager each time a change happens (i.e UpdateInterface)
     def changed(self, action):
+        # Ignore changes that don't affect this
+        if action and len(action.key) >= 1 and action.key[0].lower() in ["files", "history", "profile"]:
+            return
+
         # Clear previous rects
         self.clip_rects.clear()
         self.clip_rects_selected.clear()

src/windows/views/zoom_slider.py

@@ -46,6 +46,10 @@ class ZoomSlider(QWidget, updates.UpdateInterface):
 
     # This method is invoked by the UpdateManager each time a change happens (i.e UpdateInterface)
     def changed(self, action):
+        # Ignore changes that don't affect this
+        if action and len(action.key) >= 1 and action.key[0].lower() in ["files", "history", "profile"]:
+            return
+
         # Clear previous rects
         self.clip_rects.clear()
         self.clip_rects_selected.clear()