|
1 | 1 | ## How to contribute to OpenShot Video Editor
|
2 | 2 |
|
3 |
| -#### **Did you find a bug?** |
| 3 | +### Submitting an Issue (bug report) |
4 | 4 |
|
5 |
| -* **Please check if this bug was already reported** by searching on GitHub under [Issues](https://github.com/OpenShot/openshot-qt/issues). |
| 5 | +* **Please check if this bug was already reported** by searching on GitHub under [Issues](https://github.com/OpenShot/openshot-qt/issues?q=+). |
6 | 6 |
|
7 |
| -* If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/OpenShot/openshot-qt/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and the steps to reproduce the crash or issue. |
| 7 | +* If you're unable to find an existing report about the problem, [open a new issue](https://github.com/OpenShot/openshot-qt/issues/new?template=bug-report.md). Be sure to include a **title and clear description**, and fill in as much relevant information as possible. Include the steps to reproduce the crash or issue, and please note what operating system(s) you tried them on. (Some bugs only occur when using OpenShot on a particular OS.) |
8 | 8 |
|
9 | 9 | * Please **attach log files** if you are reporting a crash. Otherwise, we will not be able to determine the cause of the crash.
|
10 | 10 |
|
11 |
| - _Please download our latest daily installer:_ |
| 11 | +#### Reproducing a bug & collecting logs |
12 | 12 |
|
13 |
| - 1. www.openshot.org/download - click the '**Daily Builds**' button, then grab the latest build from the list. |
14 |
| - (Use the buttons below to download installers for a different Operating System.) |
15 |
| - 2. Then enable 'Debug Mode (Verbose)' in the Preferences |
16 |
| - 3. Quit OpenShot and delete both log files: |
17 |
| - * **Windows**: OpenShot stores its logs in your user profile directory (`%USERPROFILE%`, e.g. `C:\Users\username\`) |
18 |
| - * **`%USERPROFILE%/.openshot_qt/openshot-qt.log`** |
19 |
| - * **`%USERPROFILE%/.openshot_qt/libopenshot.log`** |
20 |
| - * **Linux/MacOS**: OpenShot stores its logs in your home directory (`$HOME`, e.g. `/home/username/`) |
21 |
| - * **`$HOME/.openshot_qt/openshot-qt.log`** |
22 |
| - * **`$HOME/.openshot_qt/libopenshot.log`** |
23 |
| - 4. Re-launch OpenShot and trigger the crash as quickly as possible (to keep the log files small) |
24 |
| - 5. Attach **both** log files |
| 13 | + 1. _Please download our latest daily installer:_ |
| 14 | + www.openshot.org/download - click the '**Daily Builds**' button, then grab the latest build from the list. |
| 15 | + (Use the buttons below the list to download installers for a different Operating System.) |
| 16 | + 2. **Only if the bug involves video playback or Export**, or if you were asked to by the OpenShot developers, enable 'Debug Mode (Verbose)' in the Preferences. Debug Mode adds no additional information for user interface or project-editing bugs. |
| 17 | + 3. Quit OpenShot and delete your log files, to ensure the files you submit contain only necessary information. (See below for logfile paths.) |
| 18 | + 4. Re-launch OpenShot and trigger the problem as quickly as possible, then immediately quit the program. This helps keeps the log files small and relevant. |
| 19 | + 5. Attach both log files to your issue. Github issue comments permit attaching `.log` files up to 2MB in size. You can insert the file(s) either by drag-and-drop, or using the link at the bottom of the comment edit field. |
| 20 | + |
| 21 | +#### OpenShot log file locations |
25 | 22 |
|
26 |
| -#### **Did you write a patch that fixes a bug?** |
| 23 | +##### Windows |
| 24 | + * OpenShot stores its logs in your user profile directory (`%USERPROFILE%`, e.g. `C:\Users\username\`) |
| 25 | + * **<code><var>%USERPROFILE%</var>\.openshot_qt\openshot-qt.log</code>** |
| 26 | + * **<code><var>%USERPROFILE%</var>\.openshot_qt\libopenshot.log</code>** |
27 | 27 |
|
28 |
| -* Open a new GitHub pull request with the patch. |
| 28 | +##### Linux/MacOS |
| 29 | + * OpenShot stores its logs in your home directory (`$HOME`, e.g. `/home/username/`) |
| 30 | + * **<code><var>$HOME</var>/.openshot_qt/openshot-qt.log</code>** |
| 31 | + * **<code><var>$HOME</var>/.openshot_qt/libopenshot.log</code>** |
29 | 32 |
|
30 |
| -* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable. |
| 33 | +### Submitting a Pull Request (source code patch / bug fix) |
31 | 34 |
|
32 |
| -* Before submitting, please ensure your PR passes all build / compilation / and unit tests. |
| 35 | +* Fork the repository on Github, then create a new branch for your changes. Commit the patch(es), and finally open a new GitHub Pull Request from that branch. |
33 | 36 |
|
34 |
| -OpenShot Video Editor is a volunteer effort, and a labor of love. Please be patient with any issues you find, and feel free to get involved and help us fix them! |
| 37 | +* Ensure the PR description clearly describes the problem and your solution. If the patch is related to an existing issue report, include the issue number in your description. Github recognizes trigger phrases such as "fixes #1234" or "closes #9999", and will automatically link your PR with the referenced issue(s). |
| 38 | + |
| 39 | +* After submitting, your PR will be run through a test build and various code-quality and style checks. Try to address any problems flagged by these checks. If OpenShot fails to build successfully with your changes, the PR cannot be merged until the problem is resolved. |
35 | 40 |
|
| 41 | + Submitting "in-progress" code is fine, and can often be a good way to solicit feedback from other developers. Consider marking PRs that are unfinished or still under development with a the title that begins with "WIP", or convert the PR to draft status, to indicate to the developers that your changes are not yet ready for review. |
| 42 | + |
| 43 | +OpenShot Video Editor is a volunteer effort, and a labor of love. Please be patient with any issues you find, and feel free to get involved and help us fix them! |
36 | 44 |
|
37 | 45 | Thanks!
|
38 | 46 |
|
|
0 commit comments