Housekeeping: Eliminate all star imports, etc.

- Remove most unused variables
- Reformat source to reduce overlong lines

Author: ferdnyc

src/classes/app.py

@@ -42,13 +42,13 @@
 try:
     # QtWebEngineWidgets must be loaded prior to creating a QApplication
     # But on systems with only WebKit, this will fail (and we ignore the failure)
-    from PyQt5.QtWebEngineWidgets import QWebEngineView
+    from PyQt5.QtWebEngineWidgets import QWebEngineView  # noqa
 except ImportError:
     pass
 
 try:
     # Solution to solve QtWebEngineWidgets black screen caused by OpenGL not loaded
-    from OpenGL import GL
+    from OpenGL import GL  # noqa
 except ImportError:
     pass
 
@@ -142,8 +142,11 @@ def __init__(self, *args, mode=None):
         libopenshot_version = openshot.OPENSHOT_VERSION_FULL
         if mode != "unittest" and libopenshot_version < info.MINIMUM_LIBOPENSHOT_VERSION:
             QMessageBox.warning(
-                None, _("Wrong Version of libopenshot Detected"),
-                _("<b>Version %(minimum_version)s is required</b>, but %(current_version)s was detected. Please update libopenshot or download our latest installer.") % {
+                None,
+                _("Wrong Version of libopenshot Detected"),
+                _("<b>Version %(minimum_version)s is required</b>, but %(current_version)s was detected. \
+                Please update libopenshot or download our latest installer.")
+                % {
                     "minimum_version": info.MINIMUM_LIBOPENSHOT_VERSION,
                     "current_version": libopenshot_version,
                     })

src/classes/ui_util.py

@@ -32,19 +32,19 @@
 
 # Try to get the security-patched XML functions from defusedxml
 try:
-  from defusedxml import ElementTree
+    from defusedxml import ElementTree
 except ImportError:
-  from xml.etree import ElementTree
+    from xml.etree import ElementTree
 
 from PyQt5.QtCore import QDir, QLocale
 from PyQt5.QtGui import QIcon
-from PyQt5.QtWidgets import *
+from PyQt5.QtWidgets import QApplication, QWidget, QTabWidget, QAction
 from PyQt5 import uic
 
 from classes.logger import log
 from classes import settings
 
-from . import openshot_rc
+from . import openshot_rc  # noqa
 
 DEFAULT_THEME_NAME = "Humanity"
 
@@ -73,7 +73,7 @@ def load_ui(window, path):
     # race condition. [zipimport.ZipImportError: can't decompress data; zlib not available]
     # This error only happens when cx_Freeze is used, and the app is launched.
     error = None
-    for attempt in range(1,6):
+    for attempt in range(1, 6):
         try:
             # Load ui from configured path
             uic.loadUi(path, window)
@@ -143,14 +143,19 @@ def get_icon(theme_name):
 
 
 def setup_icon(window, elem, name, theme_name=None):
-    """Using the window xml, set the icon on the given element, or if theme_name passed load that icon."""
+    """Using the window xml, set the icon on the given element,
+    or if theme_name passed load that icon."""
 
     type_filter = 'action'
     if isinstance(elem, QWidget):  # Search for widget with name instead
         type_filter = 'widget'
     # Find iconset in tree (if any)
-    iconset = window.uiTree.find('.//' + type_filter + '[@name="' + name + '"]/property[@name="icon"]/iconset')
-    if iconset != None or theme_name:  # For some reason "if iconset:" doesn't work the same as "!= None"
+    iconset = window.uiTree.find(
+        './/' + type_filter + '[@name="' + name
+        + '"]/property[@name="icon"]/iconset'
+        )
+    # For some reason "if iconset:" doesn't work the same
+    if iconset is not None or theme_name:
         if not theme_name:
             theme_name = iconset.get('theme', '')
         # Get Icon (either current theme or fallback)
@@ -170,15 +175,31 @@ def init_element(window, elem):
         connect_auto_events(window, elem, name)
 
     # Handle generic translatable properties
-    if hasattr(elem, 'setText') and hasattr(elem, 'text') and elem.text() != "":
+    if (
+            hasattr(elem, 'setText')
+            and hasattr(elem, 'text')
+            and elem.text() != ""
+            ):
         elem.setText(_translate("", elem.text()))
     if hasattr(elem, 'setToolTip') and hasattr(elem, 'toolTip') and elem.toolTip() != "":
         elem.setToolTip(_translate("", elem.toolTip()))
-    if hasattr(elem, 'setWindowTitle') and hasattr(elem, 'windowTitle') and elem.windowTitle() != "":
+    if (
+            hasattr(elem, 'setWindowTitle')
+            and hasattr(elem, 'windowTitle')
+            and elem.windowTitle() != ""
+            ):
         elem.setWindowTitle(_translate("", elem.windowTitle()))
-    if hasattr(elem, 'setTitle') and hasattr(elem, 'title') and  elem.title() != "":
+    if (
+            hasattr(elem, 'setTitle')
+            and hasattr(elem, 'title')
+            and elem.title() != ""
+            ):
         elem.setTitle(_translate("", elem.title()))
-    if hasattr(elem, 'setPlaceholderText') and hasattr(elem, 'placeholderText') and  elem.placeholderText() != "":
+    if (
+            hasattr(elem, 'setPlaceholderText')
+            and hasattr(elem, 'placeholderText')
+            and elem.placeholderText() != ""
+            ):
         elem.setPlaceholderText(_translate("", elem.placeholderText()))
     if hasattr(elem, 'setLocale'):
         elem.setLocale(QLocale().system())
@@ -226,8 +247,10 @@ def init_ui(window):
         # Loop through all actions
         for action in window.findChildren(QAction):
             init_element(window, action)
-    except:
-        log.info('Failed to initialize an element on {}'.format(window.objectName()))
+    except Exception:
+        log.info(
+            'Failed to initialize an element on %s', window.objectName())
+
 
 def center(window):
     """Center a window on the main window"""
@@ -238,5 +261,6 @@ def center(window):
     frameGm.moveCenter(centerPoint)
     window.move(frameGm.topLeft())
 
+
 def transfer_children(from_widget, to_widget):
     log.info("Transferring children from '{}' to '{}'".format(from_widget.objectName(), to_widget.objectName()))