Skip to content

Commit a7c262b

Browse files
authored
Merge branch 'develop' into fix-lib-mangling
2 parents de25d13 + 7dccd47 commit a7c262b

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

installer/build-mac-dmg.sh

+6-5
Original file line numberDiff line numberDiff line change
@@ -91,17 +91,18 @@ while [ "$(( $(date +%s) - 3600 ))" -lt "$START" ]; do
9191
notarize_status="${BASH_REMATCH[1]}"
9292

9393
if [ "$notarize_status" != "in progress" ] && [ "$notarize_status" != "" ]; then
94-
echo "Notarization Status Found: $notarize_status"
95-
break
94+
echo "Notarization Status Found: $notarize_status. Wait for notarization to appear in --notarization-history/"
95+
verify_output=$(xcrun altool --notarization-history 0 -u "[email protected]" -p "@keychain:NOTARIZE_AUTH" | grep "$REQUEST_UUID")
96+
if [ "$verify_output" != "" ]; then
97+
echo "Notarization record found, and ready for stapling!"
98+
break
99+
fi
96100
fi
97101

98102
# Wait a few seconds
99103
sleep 60
100104
done
101105

102-
echo "Check Notarization Progress... (list recent notarization records)"
103-
xcrun altool --notarization-history 0 -u "[email protected]" -p "@keychain:NOTARIZE_AUTH" | head -n 10
104-
105106
echo "Staple Notarization Ticket to DMG"
106107
xcrun stapler staple "build/$OS_DMG_NAME"
107108

src/classes/app.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@
3939
from PyQt5.QtGui import QPalette, QColor, QFontDatabase, QFont
4040
from PyQt5.QtWidgets import QApplication, QStyleFactory, QMessageBox
4141

42-
# QtWebEngineWidgets must be loaded prior to creating a QApplication
43-
from PyQt5.QtWebEngineWidgets import QWebEngineView
42+
try:
43+
# QtWebEngineWidgets must be loaded prior to creating a QApplication
44+
# But on systems with only WebKit, this will fail (and we ignore the failure)
45+
from PyQt5.QtWebEngineWidgets import QWebEngineView
46+
except ImportError:
47+
pass
4448

4549
try:
4650
# Solution to solve QtWebEngineWidgets black screen caused by OpenGL not loaded

0 commit comments

Comments
 (0)