Fixing Sentry.io OPENSHOT-5KAW: Failed to load media file into video player. Stopped using log.error for this, and added more checks for if files exist before previewing and thumbnailing them.

Author: jonoomph

src/classes/thumbnail.py

@@ -74,6 +74,9 @@ def GetThumbPath(file_id, thumbnail_frame, clear_cache=False):
 
 def GenerateThumbnail(file_path, thumb_path, thumbnail_frame, width, height, mask, overlay):
     """Create thumbnail image, and check for rotate metadata (if any)"""
+    if not os.path.exists(file_path):
+        log.warning(f"Cannot generate thumbnail for missing file: {file_path}")
+        return
 
     # Create a clip object and get the reader
     clip = openshot.Clip(file_path)

src/windows/preview_thread.py

@@ -28,6 +28,7 @@
 import time
 import sip
 import math
+import os
 
 from PyQt5.QtCore import QObject, QThread, QTimer, pyqtSlot, pyqtSignal, QCoreApplication
 from PyQt5.QtWidgets import QMessageBox
@@ -309,7 +310,8 @@ def LoadFile(self, path=None):
         """ Load a media file into the video player """
         # Check to see if this path is already loaded
         # TODO: Determine why path is passed in as an empty string instead of None
-        if path == self.clip_path or (not path and not self.clip_path):
+        if path == self.clip_path or (not path and not self.clip_path) or not os.path.exists(path):
+            log.warning(f"Cannot load missing file for preview: {path}")
             return
 
         log.info("LoadFile %s" % path)
@@ -361,8 +363,7 @@ def LoadFile(self, path=None):
                 new_clip = openshot.Clip(path)
                 self.clip_reader.AddClip(new_clip)
             except:
-                log.error('Failed to load media file into video player: %s' % path)
-                return
+                log.warning('Failed to load media file into video player: %s' % path)
 
             # Assign new clip_reader
             self.clip_path = path