Skip to content

Commit 74516aa

Browse files
committed
files views: Reconcile common code, use super()
1 parent 4dc280f commit 74516aa

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

src/windows/views/files_listview.py

+11-7
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ def startDrag(self, supportedActions):
118118
# Start drag operation
119119
drag = QDrag(self)
120120
drag.setMimeData(self.files_model.model.mimeData(self.selectionModel().selectedIndexes()))
121-
# drag.setPixmap(QIcon.fromTheme('document-new').pixmap(QSize(self.drag_item_size,self.drag_item_size)))
122121
drag.setPixmap(icon.pixmap(QSize(self.drag_item_size, self.drag_item_size)))
123122
drag.setHotSpot(QPoint(self.drag_item_size / 2, self.drag_item_size / 2))
124123
drag.exec_()
@@ -320,30 +319,35 @@ def prepare_for_delete(self):
320319

321320
def __init__(self, *args):
322321
# Invoke parent init
323-
QListView.__init__(self, *args)
322+
super().__init__(*args)
324323

325324
# Get a reference to the window object
326325
self.win = get_app().window
327326

328327
# Get Model data
329328
self.files_model = FilesModel()
329+
self.setModel(self.files_model.model)
330+
331+
# Keep track of mouse press start position to determine when to start drag
330332
self.setAcceptDrops(True)
331333
self.setDragEnabled(True)
332334
self.setDropIndicatorShown(True)
333335
self.ignore_image_sequence_paths = []
334336

335-
# Setup header columns
336-
self.setModel(self.files_model.model)
337+
# Setup header columns and layout
337338
self.setIconSize(QSize(131, 108))
338339
self.setGridSize(QSize(102, 92))
339340
self.setViewMode(QListView.IconMode)
340341
self.setResizeMode(QListView.Adjust)
341-
self.setSelectionMode(QAbstractItemView.ExtendedSelection)
342-
self.setSelectionBehavior(QAbstractItemView.SelectRows)
342+
343343
self.setUniformItemSizes(True)
344+
self.setStyleSheet('QListView::item { padding-top: 2px; }')
345+
344346
self.setWordWrap(False)
345347
self.setTextElideMode(Qt.ElideRight)
346-
self.setStyleSheet('QListView::item { padding-top: 2px; }')
348+
349+
self.setSelectionMode(QAbstractItemView.ExtendedSelection)
350+
self.setSelectionBehavior(QAbstractItemView.SelectRows)
347351

348352
# Refresh view
349353
self.refresh_view()

src/windows/views/files_treeview.py

+11-7
Original file line numberDiff line numberDiff line change
@@ -367,35 +367,39 @@ def prepare_for_delete(self):
367367
"""Remove signal handlers and prepare for deletion"""
368368
try:
369369
self.files_model.model.ModelRefreshed.disconnect()
370-
except:
370+
except Exception:
371371
pass
372372

373373
def __init__(self, *args):
374374
# Invoke parent init
375-
QTreeView.__init__(self, *args)
375+
super().__init__(*args)
376376

377377
# Get a reference to the window object
378378
self.win = get_app().window
379379

380380
# Get Model data
381381
self.files_model = FilesModel()
382+
self.setModel(self.files_model.model)
382383

383384
# Keep track of mouse press start position to determine when to start drag
384385
self.setAcceptDrops(True)
385386
self.setDragEnabled(True)
386387
self.setDropIndicatorShown(True)
387388
self.ignore_image_sequence_paths = []
388389

389-
# Setup header columns
390-
self.setModel(self.files_model.model)
390+
# Setup header columns and layout
391391
self.setIconSize(QSize(75, 62))
392392
self.setIndentation(0)
393-
self.setSelectionBehavior(QTreeView.SelectRows)
394-
self.setSelectionMode(QAbstractItemView.ExtendedSelection)
395393
self.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Expanding)
394+
395+
self.setStyleSheet('QTreeView::item { padding-top: 2px; }')
396+
396397
self.setWordWrap(False)
397398
self.setTextElideMode(Qt.ElideRight)
398-
self.setStyleSheet('QTreeView::item { padding-top: 2px; }')
399+
400+
self.setSelectionMode(QAbstractItemView.ExtendedSelection)
401+
self.setSelectionBehavior(QAbstractItemView.SelectRows)
402+
399403
self.files_model.model.ModelRefreshed.connect(self.refresh_columns)
400404

401405
# Refresh view

0 commit comments

Comments
 (0)