Skip to content

Commit 740ea00

Browse files
committed
Refactor notarization to only notarize the DMG (no more zip file or app upload)
1 parent e628b16 commit 740ea00

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

installer/build-mac-dmg.sh

+11-14
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,16 @@ codesign -s "OpenShot Studios, LLC" --force --deep --options runtime --timestamp
6262
echo "Verifying App Signing"
6363
spctl -a -vv "build/$OS_APP_NAME"
6464

65-
echo "Create Zip of .App for Notarization"
66-
ditto -c -k --keepParent "build/$OS_APP_NAME" "build/$OS_APP_ZIP"
65+
echo "Building Custom DMG"
66+
appdmg "installer/dmg-template.json" "build/$OS_DMG_NAME"
6767

68-
echo "Notarize Zip file (send to apple)"
68+
echo "Code Sign DMG"
69+
codesign -s "OpenShot Studios, LLC" --force --timestamp=http://timestamp.apple.com/ts01 "build/$OS_DMG_NAME"
70+
71+
echo "Notarize DMG file (send to apple)"
6972
# No errors uploading '/Users/jonathan/builds/7d5103a1/0/OpenShot/openshot-qt/build/test.zip'.
7073
# RequestUUID = cc285719-823f-4f0b-8e71-2df4bbbdaf72
71-
notarize_output=$(xcrun altool --notarize-app --primary-bundle-id "org.openshot.openshot-qt.zip" --username "[email protected]" --password "@keychain:NOTARIZE_AUTH" --file "build/$OS_APP_ZIP")
74+
notarize_output=$(xcrun altool --notarize-app --primary-bundle-id "org.openshot.openshot-qt.zip" --username "[email protected]" --password "@keychain:NOTARIZE_AUTH" --file "build/$OS_DMG_NAME")
7275
echo "$notarize_output"
7376

7477
echo "Parse Notarize Output and get Notarization RequestUUID"
@@ -100,18 +103,12 @@ while [ $(( $(date +%s) - 3600 )) -lt $START ]; do
100103
break
101104
fi
102105

103-
# Wait 30 seconds
104-
sleep 10
106+
# Wait a few seconds
107+
sleep 30
105108
done
106109

107-
echo "Staple Notarization Ticket to App"
108-
xcrun stapler staple "build/$OS_APP_NAME"
109-
110-
echo "Building Custom DMG"
111-
appdmg "installer/dmg-template.json" "build/$OS_DMG_NAME"
112-
113-
echo "Code Sign DMG"
114-
codesign -s "OpenShot Studios, LLC" --force --timestamp=http://timestamp.apple.com/ts01 "build/$OS_DMG_NAME"
110+
echo "Check Notarization Progress... (list recent notarization records)"
111+
xcrun altool --notarization-history 0 -u "[email protected]" -p "@keychain:NOTARIZE_AUTH"
115112

116113
echo "Staple Notarization Ticket to DMG"
117114
xcrun stapler staple "build/$OS_DMG_NAME"

0 commit comments

Comments
 (0)