Skip to content

Commit 601cea0

Browse files
committed
Implementing some code cleanup suggestions
1 parent 09f62a3 commit 601cea0

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/windows/views/webview.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3150,7 +3150,7 @@ def render_cache_json(self):
31503150
if not cache_object or cache_object.Count() <= 0:
31513151
return
31523152
# Get the JSON from the cache object (i.e. which frames are cached)
3153-
cache_json = self.window.timeline_sync.timeline.GetCache().Json()
3153+
cache_json = cache_object.Json()
31543154
cache_dict = json.loads(cache_json)
31553155
cache_version = cache_dict["version"]
31563156

src/windows/views/zoom_slider.py

+5-10
Original file line numberDiff line numberDiff line change
@@ -119,28 +119,23 @@ def paintEvent(self, event, *args):
119119
clip_pen.setCosmetic(True)
120120
painter.setPen(clip_pen)
121121

122-
clip_pen = QPen(QBrush(QColor("#53a0ed")), 1.5)
123-
clip_pen.setCosmetic(True)
124122
selected_clip_pen = QPen(QBrush(QColor("Red")), 1.5)
125123
selected_clip_pen.setCosmetic(True)
126124

127-
scroll_color = QColor("#53a0ed")
128-
scroll_color.setAlphaF(0.25)
125+
scroll_color = QColor("#4053a0ed")
129126
scroll_pen = QPen(QBrush(scroll_color), 2.0)
130127
scroll_pen.setCosmetic(True)
131128

132-
marker_color = QColor("#53a0ed")
133-
marker_color.setAlphaF(0.25)
129+
marker_color = QColor("#4053a0ed")
134130
marker_pen = QPen(QBrush(marker_color), 1.0)
135131
marker_pen.setCosmetic(True)
136132

137-
playhead_color = QColor("Red")
133+
playhead_color = QColor(Qt.red)
138134
playhead_color.setAlphaF(0.5)
139135
playhead_pen = QPen(QBrush(playhead_color), 1.0)
140136
playhead_pen.setCosmetic(True)
141137

142-
handle_color = QColor("#53a0ed")
143-
handle_color.setAlphaF(0.65)
138+
handle_color = QColor("#a653a0ed")
144139
handle_pen = QPen(QBrush(handle_color), 1.5)
145140
handle_pen.setCosmetic(True)
146141

@@ -365,7 +360,7 @@ def delayed_resize_callback(self):
365360
scroll_width_seconds = normalized_scroll_width * project_duration
366361
tick_pixels = 100
367362
if self.scrollbar_position[3] > 0.0:
368-
# Calculate the new zoom factor, based on 100 pixels per tick
363+
# Calculate the new zoom factor, based on pixels per tick
369364
zoom_factor = scroll_width_seconds / (self.scrollbar_position[3] / tick_pixels)
370365

371366
# Set scroll width (and send signal)

0 commit comments

Comments
 (0)