Merge pull request #3909 from KilianMaes/develop

Solve bug: Credits window not popping up

Author: ferdnyc

src/windows/models/credits_model.py

@@ -56,7 +56,7 @@ def update_model(self, filter=None, clear=True):
 
         for person in self.credits_list:
             # Get details of person
-            data = defaultdict("")
+            data = defaultdict(str)
             data.update({
                 "name": person.get("name"),
                 "email": person.get("email"),
@@ -82,7 +82,7 @@ def update_model(self, filter=None, clear=True):
             # Append type icon (PayPal, Kickstarter, Bitcoin, or Patreon)
             item = QStandardItem()
             for contrib in [n for n in self.icon_mapping if n in data["icons"]]:
-                (icon, tooltip) = self.icon_mapping.get(contrib, (None, None))
+                (tooltip, icon) = self.icon_mapping.get(contrib, (None, None))
                 item.setIcon(icon)
                 item.setToolTip(tooltip)
             item.setFlags(flags)