Apply suggestions from code review

Applying @ferdnyc suggestions for 'less chatty' and more descriptive exceptions, where needed.

Co-authored-by: Frank Dana <[email protected]>

Author: jonoomph

src/windows/main_window.py

@@ -292,7 +292,7 @@ def create_lock_file(self):
                     f.write(lock_value)
                 break
             except Exception:
-                log.warning('Failed to write lock file (attempt: %s)' % attempts)
+                log.debug('Failed to write lock file (attempt: %s)' % attempts)
                 attempts -= 1
                 sleep(0.25)
 
@@ -307,7 +307,7 @@ def destroy_lock_file(self):
                 os.remove(lock_path)
                 break
             except Exception:
-                log.warning('Failed to destroy lock file (attempt: %s)' % attempts)
+                log.debug('Failed to destroy lock file (attempt: %s)' % attempts)
                 attempts -= 1
                 sleep(0.25)
 
@@ -2591,7 +2591,7 @@ def FrameExported(self, title_message, start_frame, end_frame, current_frame):
             self.unity_launcher.set_property("progress", current_frame / (end_frame - start_frame))
             self.unity_launcher.set_property("progress_visible", True)
         except Exception:
-            log.warning('Failed to notify unity launcher of export progress. Frame: %s' % current_frame)
+            log.debug('Failed to notify unity launcher of export progress. Frame: %s' % current_frame)
 
     def ExportFinished(self, path):
         """Show completion in Unity Launcher (if connected)"""
@@ -2600,7 +2600,7 @@ def ExportFinished(self, path):
             self.unity_launcher.set_property("progress", 0.0)
             self.unity_launcher.set_property("progress_visible", False)
         except Exception:
-            log.warning('Failed to notify unity launcher of export progress. Completed.')
+            log.debug('Failed to notify unity launcher of export progress. Completed.')
 
     def __init__(self, mode=None):
 

src/windows/preferences.py

@@ -498,7 +498,7 @@ def text_value_changed(self, widget, param, value=None):
             if not value:
                 value = widget.toPlainText()
         except:
-            log.warning('Failed to get plain text from widget')
+            log.debug('Failed to get plain text from widget')
 
         # If this setting is a keyboard mapping, parse it first
         if param.get("category") == "Keyboard":

src/windows/title_editor.py

@@ -222,7 +222,7 @@ def load_svg_template(self):
                 self.settingsContainer.layout().removeWidget(child)
                 child.deleteLater()
             except Exception:
-                log.warning('Failed to delete child settings widget')
+                log.debug('Failed to delete child settings widget')
 
         # Get text nodes and rect nodes
         self.text_node = self.xmldoc.getElementsByTagName('text')
@@ -441,7 +441,7 @@ def update_font_color_button(self):
                 color = txt[5:]
             except Exception:
                 # If the color was in an invalid format, try the next text element
-                log.warning('Failed to parse color value from text element')
+                log.debug('Failed to parse {} as color value'.format(txt))
 
             opacity = self.find_in_list(ar, "opacity:")
 
@@ -450,7 +450,7 @@ def update_font_color_button(self):
                 txt = ar[opacity]
                 opacity = float(txt[8:])
             except Exception:
-                log.warning('Failed to parse opacity value from text element')
+                log.debug('Failed to parse {} as opacity value'.format(txt))
 
             # Default the font color to white if non-existing
             if color is None:

src/windows/views/blender_listview.py

@@ -210,7 +210,7 @@ def text_value_changed(self, widget, param, value=None):
             if not value:
                 value = widget.toPlainText()
         except Exception:
-            log.warning('Failed to read plain text value from widget')
+            log.debug('Failed to read plain text value from widget')
             return
         self.params[param["name"]] = value.replace("\n", "\\n")
         # XXX: This will log every individual KEYPRESS in the text field.

src/windows/views/properties_tableview.py

@@ -181,7 +181,7 @@ def mouseMoveEvent(self, event):
             except Exception:
                 # If item is deleted during this drag... an exception can occur
                 # Just ignore, since this is harmless
-                log.warning('Failed to access data on selected label widget')
+                log.debug('Failed to access data on selected label widget')
 
             property_key = cur_property[0]
             property_name = cur_property[1]["name"]

src/windows/views/timeline_webview.py

@@ -229,7 +229,7 @@ def update_clip_data(self, clip_json, only_basic_props=True, ignore_reader=False
                 clip_data = clip_json
         except Exception:
             # Failed to parse json, do nothing
-            log.warning('Failed to parse clip JSON data')
+            log.warning('Failed to parse clip JSON data', exc_info=1)
 
         # Search for matching clip in project data (if any)
         existing_clip = Clip.get(id=clip_data["id"])

src/windows/views/tutorial.py

@@ -297,7 +297,7 @@ def exit_manager(self):
             self.win.dockProperties.visibilityChanged.disconnect()
             self.win.dockVideo.visibilityChanged.disconnect()
         except Exception:
-            log.warning('Failed to properly disconnect from dock signals')
+            log.debug('Failed to properly disconnect from dock signals', exc_info=1)
 
         # Close dialog window
         self.close_dialogs()