Skip to content

Commit 419aa10

Browse files
committed
Use existing File object data when creating Clip objects... instead of a new Clip object reader.
1 parent c126b83 commit 419aa10

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

src/windows/add_to_timeline.py

+1-11
Original file line numberDiff line numberDiff line change
@@ -194,23 +194,13 @@ def accept(self):
194194
new_clip["layer"] = track_num
195195
new_clip["file_id"] = file.id
196196
new_clip["title"] = filename
197+
new_clip["reader"] = file.data
197198

198199
# Skip any clips that are missing a 'reader' attribute
199200
# TODO: Determine why this even happens, as it shouldn't be possible
200201
if not new_clip.get("reader"):
201202
continue # Skip to next file
202203

203-
# Overwrite frame rate (incase the user changed it in the File Properties)
204-
file_properties_fps = float(file.data["fps"]["num"]) / float(file.data["fps"]["den"])
205-
file_fps = float(new_clip["reader"]["fps"]["num"]) / float(new_clip["reader"]["fps"]["den"])
206-
fps_diff = file_fps / file_properties_fps
207-
new_clip["reader"]["fps"]["num"] = file.data["fps"]["num"]
208-
new_clip["reader"]["fps"]["den"] = file.data["fps"]["den"]
209-
# Scale duration / length / and end properties
210-
new_clip["reader"]["duration"] *= fps_diff
211-
new_clip["end"] *= fps_diff
212-
new_clip["duration"] *= fps_diff
213-
214204
# Check for optional start and end attributes
215205
start_time = 0
216206
end_time = new_clip["reader"]["duration"]

src/windows/views/webview.py

+1-11
Original file line numberDiff line numberDiff line change
@@ -2984,6 +2984,7 @@ def callback(self, data, callback_data):
29842984
new_clip = json.loads(c.Json())
29852985
new_clip["file_id"] = file.id
29862986
new_clip["title"] = filename
2987+
new_clip["reader"] = file.data
29872988

29882989
# Skip any clips that are missing a 'reader' attribute
29892990
if not new_clip.get("reader"):
@@ -3004,17 +3005,6 @@ def callback(self, data, callback_data):
30043005
if file.data["media_type"] == "image":
30053006
new_clip["end"] = get_app().get_settings().get("default-image-length") # default to 8 seconds
30063007

3007-
# Overwrite frame rate (incase the user changed it in the File Properties)
3008-
file_properties_fps = float(file.data["fps"]["num"]) / float(file.data["fps"]["den"])
3009-
file_fps = float(new_clip["reader"]["fps"]["num"]) / float(new_clip["reader"]["fps"]["den"])
3010-
fps_diff = file_fps / file_properties_fps
3011-
new_clip["reader"]["fps"]["num"] = file.data["fps"]["num"]
3012-
new_clip["reader"]["fps"]["den"] = file.data["fps"]["den"]
3013-
# Scale duration / length / and end properties
3014-
new_clip["reader"]["duration"] *= fps_diff
3015-
new_clip["end"] *= fps_diff
3016-
new_clip["duration"] *= fps_diff
3017-
30183008
# Add clip to timeline
30193009
self.update_clip_data(new_clip, only_basic_props=False, transaction_id=tid)
30203010

0 commit comments

Comments
 (0)