Merge pull request #4012 from OpenShot/profiling-improvements

Refactor due to profiling improvements (in libopenshot)

Author: jonoomph

src/effects/icons/bars.png

@@ -422,14 +422,6 @@
     "values": [],
     "restart": true
   },
-  {
-    "value": true,
-    "title": "Process Video Frames in Parallel (Experimental)",
-    "type": "bool",
-    "restart": false,
-    "category": "Performance",
-    "setting": "omp_threads_enabled"
-  },
   {
     "min": 0,
     "max": 128,

src/effects/icons/blur.png

@@ -67,7 +67,7 @@ class Export(QDialog):
 
     ExportStarted = pyqtSignal(str, int, int)
     ExportFrame = pyqtSignal(str, int, int, int, str)
-    ExportEnded = pyqtSignal(str)        
+    ExportEnded = pyqtSignal(str)
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -111,7 +111,6 @@ def __init__(self, *args, **kwargs):
         self.txtChannels.setVisible(False)
 
         # Set OMP thread disabled flag (for stability)
-        openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
         openshot.Settings.Instance().HIGH_QUALITY_SCALING = True
 
         project_timeline = get_app().window.timeline_sync.timeline
@@ -1012,12 +1011,6 @@ def titlestring(sec, fps, mess):
         # Clear all cache
         self.timeline.ClearAllCache()
 
-        # Re-set OMP thread enabled flag
-        if self.s.get("omp_threads_enabled"):
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
-        else:
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
-
         # Return scale mode to lower quality scaling (for faster previews)
         openshot.Settings.Instance().HIGH_QUALITY_SCALING = False
 
@@ -1066,14 +1059,6 @@ def reject(self):
                 # Resume export
                 return
 
-        # Re-set OMP thread enabled flag
-        # NOTE: This is always called when closing the export modal, and thus
-        # the keyframes are always scaled back to the original FPS if needed.
-        if self.s.get("omp_threads_enabled"):
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
-        else:
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
-
         # Return scale mode to lower quality scaling (for faster previews)
         openshot.Settings.Instance().HIGH_QUALITY_SCALING = False
 

src/effects/icons/brightness.png

@@ -2927,12 +2927,6 @@ def __init__(self, *args, mode=None):
         else:
             openshot.Settings.Instance().PLAYBACK_AUDIO_DEVICE_NAME = ""
 
-        # Set OMP thread enabled flag (for stability)
-        if s.get("omp_threads_enabled"):
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
-        else:
-            openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
-
         # Set scaling mode to lower quality scaling (for faster previews)
         openshot.Settings.Instance().HIGH_QUALITY_SCALING = False
 

src/effects/icons/caption.png

@@ -485,14 +485,6 @@ def bool_value_changed(self, widget, param, state):
                 # Stop autosave timer
                 get_app().window.auto_save_timer.stop()
 
-        elif param["setting"] == "omp_threads_enabled":
-            if (state == Qt.Checked):
-                # Enable OMP multi-threading
-                openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
-            else:
-                # Disable OMP multi-threading
-                openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
-
         # Check for restart
         self.check_for_restart(param)
 

src/effects/icons/chromakey.png

@@ -372,6 +372,9 @@
    <attribute name="dockWidgetArea">
     <number>4</number>
    </attribute>
+   <property name="visible">
+    <bool>false</bool>
+   </property>
    <widget class="QWidget" name="dockWidgetContentsCaption">
     <layout class="QGridLayout" name="gridLayoutCaption">
      <property name="leftMargin">