Work around PyQt5 bug with argument types (#3776)

Qt's getOpenFileUrls() and related Url-based functions are supposed to
take a QUrl for the 'directory' argument (starting path), but until
PyQt5 5.13.1 the argument was mis-typed as str.

Author: ferdnyc

src/classes/app.py

@@ -32,6 +32,7 @@
 import platform
 import sys
 import traceback
+from distutils.version import LooseVersion
 
 from PyQt5.QtCore import PYQT_VERSION_STR
 from PyQt5.QtCore import QT_VERSION_STR
@@ -57,7 +58,7 @@
     QApplication.setAttribute(Qt.AA_EnableHighDpiScaling)
     QApplication.setAttribute(Qt.AA_ShareOpenGLContexts)
 except AttributeError:
-    pass # Quietly fail for older Qt5 versions
+    pass  # Quietly fail for older Qt5 versions
 
 
 def get_app():
@@ -84,7 +85,7 @@ def __init__(self, *args, mode=None):
             log.info('Starting new session'.center(48))
 
             from classes import settings, project_data, updates, language, ui_util, logger_libopenshot
-            from . import openshot_rc
+            from . import openshot_rc  # noqa
             import openshot
 
             # Re-route stdout and stderr to logger
@@ -130,6 +131,10 @@ def __init__(self, *args, mode=None):
         self.settings = settings.SettingStore()
         self.settings.load()
 
+        # Set up distutils Version instance for PyQt version checks
+        self.pyqt_version = LooseVersion(PYQT_VERSION_STR)
+        log.debug("Stored PyQt version as %s", repr(self.pyqt_version))
+
         # Init and attach exception handler
         from classes import exceptions
         sys.excepthook = exceptions.ExceptionHandler
@@ -141,9 +146,12 @@ def __init__(self, *args, mode=None):
         _ = self._tr
         libopenshot_version = openshot.OPENSHOT_VERSION_FULL
         if mode != "unittest" and libopenshot_version < info.MINIMUM_LIBOPENSHOT_VERSION:
-            QMessageBox.warning(None, _("Wrong Version of libopenshot Detected"),
-                                      _("<b>Version %(minimum_version)s is required</b>, but %(current_version)s was detected. Please update libopenshot or download our latest installer.") %
-                                {"minimum_version": info.MINIMUM_LIBOPENSHOT_VERSION, "current_version": libopenshot_version})
+            QMessageBox.warning(
+                None, _("Wrong Version of libopenshot Detected"),
+                _("<b>Version %(minimum_version)s is required</b>, but %(current_version)s was detected. Please update libopenshot or download our latest installer.") % {
+                    "minimum_version": info.MINIMUM_LIBOPENSHOT_VERSION,
+                    "current_version": libopenshot_version,
+                    })
             # Stop launching and exit
             sys.exit()
 
@@ -175,9 +183,13 @@ def __init__(self, *args, mode=None):
             os.unlink(TEST_PATH_FILE)
             os.rmdir(TEST_PATH_DIR)
         except PermissionError as ex:
-            log.error('Failed to create PERMISSION/test.osp file (likely permissions error): %s' % TEST_PATH_FILE, exc_info=1)
-            QMessageBox.warning(None, _("Permission Error"),
-                                      _("%(error)s. Please delete <b>%(path)s</b> and launch OpenShot again." % {"error": str(ex), "path": info.USER_PATH}))
+            log.error('Failed to create file %s', TEST_PATH_FILE, exc_info=1)
+            QMessageBox.warning(
+                None, _("Permission Error"),
+                _("%(error)s. Please delete <b>%(path)s</b> and launch OpenShot again." % {
+                    "error": str(ex),
+                    "path": info.USER_PATH,
+                }))
             # Stop launching and exit
             raise
             sys.exit()

src/windows/main_window.py

@@ -51,7 +51,8 @@
 import openshot  # Python module for libopenshot (required video editing module installed separately)
 
 from windows.views.timeline_webview import TimelineWebView
-from classes import info, ui_util, openshot_rc, settings, qt_types, updates
+from classes import info, ui_util, settings, qt_types, updates
+from classes import openshot_rc  # noqa
 from classes.app import get_app
 from classes.logger import log
 from classes.timeline import TimelineSync
@@ -760,9 +761,20 @@ def actionImportFiles_trigger(self, event):
         if not recommended_path or not os.path.exists(recommended_path):
             recommended_path = os.path.join(info.HOME_PATH)
 
+        # PyQt through 5.13.0 had the 'directory' argument mis-typed as str
+        if get_app().pyqt_version < '5.13.1':
+            dir_type = "str"
+            start_location = str(recommended_path)
+        else:
+            dir_type = "QUrl"
+            start_location = QUrl.fromLocalFile(recommended_path)
+
+        log.debug("Calling getOpenFileURLs() with %s directory argument", dir_type)
         qurl_list = QFileDialog.getOpenFileUrls(
-            self, _("Import Files..."),
-            QUrl.fromLocalFile(recommended_path))[0]
+            self,
+            _("Import Files..."),
+            start_location,
+            )[0]
 
         # Set cursor to waiting
         app.setOverrideCursor(QCursor(Qt.WaitCursor))