Error handler for OpenCV effect not compiled with library

Author: BrennoCaldato

src/classes/effect_init.py

@@ -30,8 +30,8 @@
 # solution to providing the pre-processing params needed for these special effects.
 
 effect_options = {
-    # TODO: Remove Bars example options
-    "Bars": [
+    # TODO: Remove Example example options
+    "Example": [
         {
             "title": "Region",
             "setting": "region",
@@ -124,10 +124,6 @@
                     "value": "MEDIANFLOW",
                     "name": "MEDIANFLOW"
                 },
-                {
-                    "value": "GOTURN",
-                    "name": "GOTURN"
-                },
                 {
                     "value": "MOSSE",
                     "name": "MOSSE"

src/windows/process_effect.py

@@ -51,6 +51,9 @@ class ProcessEffect(QDialog):
     ui_path = os.path.join(info.PATH, 'windows', 'ui', 'process-effect.ui')
 
     def __init__(self, clip_id, effect_name, effect_params):
+        
+        if not openshot.Clip().COMPILED_WITH_CV:
+            raise ModuleNotFoundError("Openshot not compiled with OpenCV")
 
         # Create dialog class
         QDialog.__init__(self)
@@ -59,6 +62,7 @@ def __init__(self, clip_id, effect_name, effect_params):
         self.effect_name = effect_name
         self.context = {}
 
+        # Access C++ timeline and find the Clip instance which this effect should be applied to
         timeline_instance = get_app().window.timeline_sync.timeline
         for clip_instance in timeline_instance.Clips():
             if clip_instance.Id() == self.clip_id:
@@ -195,7 +199,7 @@ def __init__(self, clip_id, effect_name, effect_params):
         # flag to close the clip processing thread
         self.cancel_clip_processing = False
         self.effect = None
-        
+
     def spinner_value_changed(self, widget, param, value):
         """Spinner value change callback"""
         self.context[param["setting"]] = value
@@ -293,19 +297,11 @@ def accept(self):
         # Print effect settings
         log.info(self.context)
 
-        # DO WORK HERE, and periodically set progressBar value
-        # Access C++ timeline and find the Clip instance which this effect should be applied to
-
         # Create effect Id and protobuf data path
         ID = get_app().project.generate_id()
 
-        protobufFolderPath = os.path.join(info.PATH, '..', 'protobuf_data')
-        # Check if protobuf data folder exists, otherwise it will create one
-        if not os.path.exists(protobufFolderPath):
-            os.mkdir(protobufFolderPath)
-
         # Create protobuf data path
-        protobufPath = os.path.join(protobufFolderPath, ID + '.data')
+        protobufPath = os.path.join(info.PROTOBUF_DATA_PATH, ID + '.data')
 
         # Load into JSON string info abou protobuf data path
         jsonString = self.generateJson(protobufPath)
@@ -359,7 +355,7 @@ def generateJson(self, protobufPath):
         if self.effect_name == "Tracker":
 
             # Set tracker info in JSON string
-            # Get selected tracker [KCF, MIL, TLD, BOOSTING, MEDIANFLOW, GOTURN, MOOSE, CSRT]
+            # Get selected tracker [KCF, MIL, TLD, BOOSTING, MEDIANFLOW, MOOSE, CSRT]
             trackerType = self.context["tracker-type"]
             jsonString += ',"tracker_type": "%s"' % trackerType
 

src/windows/views/timeline_webview.py

@@ -1915,6 +1915,7 @@ def Slice_Triggered(self, action, clip_ids, trans_ids, playhead_position=0):
                 right_clip.data.pop('id')
                 right_clip.key.pop(1)
 
+                # Generate new ID to effects on the right (so they become new ones)
                 for clip_propertie_name, propertie_value in right_clip.data.items() :
                     if clip_propertie_name == "effects":
                         for item in propertie_value:
@@ -2962,18 +2963,25 @@ def addEffect(self, effect_names, position):
         for clip in possible_clips:
             if js_position == 0 or (clip.data["position"] <= js_position <= clip.data["position"] + (clip.data["end"] - clip.data["start"])):
                 log.info("Applying effect to clip")
-                log.info(clip)
-                print(name)
-                print(effect_options)
                 # Handle custom effect dialogs
                 if name in effect_options:
-                    
+
                     # Get effect options
                     effect_params = effect_options.get(name)
 
                     # Show effect pre-processing window
                     from windows.process_effect import ProcessEffect
-                    win = ProcessEffect(clip.id, name, effect_params)
+
+                    try:
+                        win = ProcessEffect(clip.id, name, effect_params)
+
+                    except ModuleNotFoundError as e:
+                        print("[ERROR]: " + str(e))
+                        return
+
+                    print("Effect %s" % name)
+                    print("Effect options: %s" % effect_options)
+                    
                     # Run the dialog event loop - blocking interaction on this window during this time
                     result = win.exec_()
 
@@ -2985,6 +2993,7 @@ def addEffect(self, effect_names, position):
 
                     # Create Effect
                     effect = win.effect # effect.Id already set
+
                     if effect is None:
                         break
                 else: