Updating timeline changed callback to always reset the current value of ENABLE_PLAYBACK_CACHING. For example, sometimes we have already disabled this setting before changing the timeline data - and we would like it to stay disabled until further notice. This method was accidentally re-enabling the caching when we were not expecting it to.

Author: jonoomph

src/classes/timeline.py

@@ -79,6 +79,7 @@ def changed(self, action):
             return
 
         # Disable video caching temporarily
+        caching_value = openshot.Settings.Instance().ENABLE_PLAYBACK_CACHING
         openshot.Settings.Instance().ENABLE_PLAYBACK_CACHING = False
 
         try:
@@ -111,8 +112,8 @@ def changed(self, action):
             log.info("Error applying JSON to timeline object in libopenshot: %s. %s" %
                      (e, action.json(is_array=True)))
 
-        # Enable video caching
-        openshot.Settings.Instance().ENABLE_PLAYBACK_CACHING = True
+        # Resume video caching original value
+        openshot.Settings.Instance().ENABLE_PLAYBACK_CACHING = caching_value
 
     def MaxSizeChangedCB(self, new_size):
         """Callback for max sized change (i.e. max size of video widget)"""