Merge pull request #4159 from OpenShot/assets-folder-name-collision

Prevent Assets Folder Name Collision

Author: JacksonRG

src/classes/assets.py

@@ -26,6 +26,7 @@
  """
 
 import os
+import shutil
 from classes import info
 from classes.logger import log
 
@@ -37,17 +38,31 @@ def get_assets_path(file_path=None, create_paths=True):
         return info.USER_PATH
 
     try:
-        # Generate asset folder name, max 30 chars of filename + "_assets"
+        # Generate asset folder name filename + "_assets"
         file_path = file_path
         asset_filename = os.path.splitext(os.path.basename(file_path))[0]
-        asset_folder_name = asset_filename[:30] + "_assets"
+        asset_folder_name = asset_filename[:248] + "_assets" #Windows max name size is 255. 248 = 255 - len("_assets")
         asset_path = os.path.join(os.path.dirname(file_path), asset_folder_name)
 
+        # Previous Assets File Name Convention.
+        # We can remove the 30_char variables after 05/27/2022
+        asset_folder_name_30_char = asset_filename[:30] + "_assets"
+        asset_path_30_char = os.path.join(os.path.dirname(file_path), asset_folder_name_30_char)
+
         # Create asset folder, if necessary
         if create_paths:
             if not os.path.exists(asset_path):
-                os.mkdir(asset_path)
-                log.info("Asset dir created as {}".format(asset_path))
+                if os.path.exists(asset_path_30_char):
+                    #copy assets folder, if it follows the previous naming convention
+                    #must leave a copy for possible projects that shared the folder.
+                    try:
+                        shutil.copytree(asset_path_30_char, asset_path)
+                        log.info("Copying shortened asset folder. {}".format(asset_path))
+                    except:
+                        log.error("Could not make a copy of assets folder")
+                else:
+                    os.mkdir(asset_path)
+                    log.info("Asset dir created as {}".format(asset_path))
             else:
                 log.info("Using existing asset folder {}".format(asset_path))