Skip to content

Commit 0dce983

Browse files
committed
codacy, and redraw on resize
1 parent 57b4f0e commit 0dce983

File tree

2 files changed

+16
-32
lines changed

2 files changed

+16
-32
lines changed

src/timeline/js/directives/ruler.js

+16-16
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ App.directive("tlBody", function () {
120120
if (e.which === 2) { // middle button
121121
e.preventDefault();
122122
is_scrolling = true;
123-
starting_scrollbar = {x: $('#scrolling_tracks').scrollLeft(), y: $('#scrolling_tracks').scrollTop()};
123+
starting_scrollbar = {x: $("#scrolling_tracks").scrollLeft(), y: $("#scrolling_tracks").scrollTop()};
124124
starting_mouse_position = {x: e.pageX, y: e.pageY};
125125
element.addClass("drag_cursor");
126126
}
@@ -197,11 +197,11 @@ App.directive("tlRuler", function ($timeout) {
197197
ruler = $('#ruler');
198198
$("#ruler span").remove();
199199

200-
startPos = scope.scrollLeft;
201-
endPos = scope.scrollLeft + $("body").width();
202-
fpt = framesPerTick(scope.pixelsPerSecond, scope.project.fps.num ,scope.project.fps.den);
203-
fps = scope.project.fps.num / scope.project.fps.den;
204-
time = [ startPos / scope.pixelsPerSecond, endPos / scope.pixelsPerSecond];
200+
let startPos = scope.scrollLeft;
201+
let endPos = scope.scrollLeft + $("body").width();
202+
let fpt = framesPerTick(scope.pixelsPerSecond, scope.project.fps.num ,scope.project.fps.den);
203+
let fps = scope.project.fps.num / scope.project.fps.den;
204+
let time = [ startPos / scope.pixelsPerSecond, endPos / scope.pixelsPerSecond];
205205

206206
if (fpt > fps) {
207207
// Make sure seconds don't change when scrolling right and left
@@ -212,38 +212,38 @@ App.directive("tlRuler", function ($timeout) {
212212
}
213213
time[1] -= time[1]%1 - 1;
214214

215-
startFrame = time[0] * Math.round(fps);
216-
endFrame = time[1] * Math.round(fps);
215+
let startFrame = time[0] * Math.round(fps);
216+
let endFrame = time[1] * Math.round(fps);
217217

218-
frame = startFrame;
218+
let frame = startFrame;
219219
while ( frame <= endFrame){
220-
t = frame / fps;
221-
pos = t * scope.pixelsPerSecond;
222-
tickSpan = $('<span style="left:'+pos+'px;"></span>');
220+
let t = frame / fps;
221+
let pos = t * scope.pixelsPerSecond;
222+
let tickSpan = $('<span style="left:'+pos+'px;"></span>');
223223
tickSpan.addClass("tick_mark");
224224

225225
if ((frame) % (fpt * 2) == 0) {
226226
// Alternating long marks with times marked
227-
timeSpan = $('<span style="left:'+pos+'px;"></span>');
227+
let timeSpan = $('<span style="left:'+pos+'px;"></span>');
228228
timeSpan.addClass("ruler_time");
229-
timeText = secondsToTime(t, scope.project.fps.num, scope.project.fps.den);
229+
let timeText = secondsToTime(t, scope.project.fps.num, scope.project.fps.den);
230230
timeSpan[0].innerText = timeText['hour'] + ':' +
231231
timeText['min'] + ':' +
232232
timeText['sec'];
233233
if (fpt < Math.round(fps)) {
234234
timeSpan[0].innerText += ',' + timeText['frame'];
235235
}
236236
tickSpan[0].style['height'] = '20px';
237+
ruler.append(timeSpan);
237238
}
238-
ruler.append(timeSpan);
239239
ruler.append(tickSpan);
240240

241241
frame += fpt;
242242
}
243243
return;
244244
};
245245

246-
scope.$watch("project.scale + project.duration + scrollLeft", function (val) {
246+
scope.$watch("project.scale + project.duration + scrollLeft + element.width()", function (val) {
247247
if (val) {
248248
$timeout(function () {
249249
drawTimes();

src/windows/views/webview_backend/webkit.py

-16
Original file line numberDiff line numberDiff line change
@@ -123,19 +123,3 @@ def keyPressEvent(self, event):
123123
else:
124124
# Ignore most keypresses
125125
event.ignore()
126-
127-
def wheelEvent(self, event):
128-
""" Mousewheel scrolling """
129-
if event.modifiers() & Qt.ShiftModifier:
130-
event.accept()
131-
frame = self.page().mainFrame()
132-
# Compute scroll offset from wheel motion
133-
tick_scale = 120
134-
steps = int(event.angleDelta().y() / tick_scale)
135-
delta = -(steps * 100)
136-
log.debug("Scrolling horizontally by %d pixels", delta)
137-
# Update the scroll position using AngularJS
138-
js = "$('body').scope().scrollLeft({});".format(delta)
139-
frame.evaluateJavaScript(js)
140-
else:
141-
super().wheelEvent(event)

0 commit comments

Comments
 (0)