Upgrading to JUCE 7.0.10, which includes fixes to Timers (which were breaking on win32)

Author: jonoomph

JuceLibraryCode/AppConfig.h

@@ -36,14 +36,14 @@
 // BEGIN SECTION A
 
 #ifndef JUCE_DISPLAY_SPLASH_SCREEN
- #define JUCE_DISPLAY_SPLASH_SCREEN 0
+ #define JUCE_DISPLAY_SPLASH_SCREEN 1
 #endif
 
 // END SECTION A
 
 #define JUCE_USE_DARK_SPLASH_SCREEN 1
 
-#define JUCE_PROJUCER_VERSION 0x70008
+#define JUCE_PROJUCER_VERSION 0x7000a
 
 //==============================================================================
 #define JUCE_MODULE_AVAILABLE_juce_audio_basics         1

JuceLibraryCode/modules/juce_audio_basics/juce_audio_basics.h

@@ -32,7 +32,7 @@
 
   ID:                 juce_audio_basics
   vendor:             juce
-  version:            7.0.8
+  version:            7.0.10
   name:               JUCE audio and MIDI data classes
   description:        Classes for audio buffer manipulation, midi message handling, synthesis, etc.
   website:            http://www.juce.com/juce
@@ -124,3 +124,10 @@ JUCE_END_IGNORE_WARNINGS_MSVC
 #include "synthesisers/juce_Synthesiser.h"
 #include "audio_play_head/juce_AudioPlayHead.h"
 #include "utilities/juce_AudioWorkgroup.h"
+#include "midi/ump/juce_UMPBytesOnGroup.h"
+#include "midi/ump/juce_UMPDeviceInfo.h"
+
+namespace juce
+{
+    namespace ump = universal_midi_packets;
+}

JuceLibraryCode/modules/juce_audio_basics/midi/juce_MidiMessage.cpp

@@ -685,6 +685,11 @@ MidiMessage MidiMessage::createSysExMessage (const void* sysexData, const int da
     return MidiMessage (m, dataSize + 2);
 }
 
+MidiMessage MidiMessage::createSysExMessage (Span<const std::byte> data)
+{
+    return createSysExMessage (data.data(), (int) data.size());
+}
+
 const uint8* MidiMessage::getSysExData() const noexcept
 {
     return isSysEx() ? getRawData() + 1 : nullptr;

JuceLibraryCode/modules/juce_audio_basics/midi/juce_MidiMessage.h

@@ -218,6 +218,13 @@ class JUCE_API  MidiMessage
     */
     int getSysExDataSize() const noexcept;
 
+    /** Returns a span that bounds the sysex body bytes contained in this message. */
+    Span<const std::byte> getSysExDataSpan() const noexcept
+    {
+        return { reinterpret_cast<const std::byte*> (getSysExData()),
+                 (size_t) getSysExDataSize() };
+    }
+
     //==============================================================================
     /** Returns true if this message is a 'key-down' event.
 
@@ -855,6 +862,10 @@ class JUCE_API  MidiMessage
     static MidiMessage createSysExMessage (const void* sysexData,
                                            int dataSize);
 
+    /** Creates a system-exclusive message.
+        The data passed in is wrapped with header and tail bytes of 0xf0 and 0xf7.
+    */
+    static MidiMessage createSysExMessage (Span<const std::byte> data);
 
     //==============================================================================
    #ifndef DOXYGEN

JuceLibraryCode/modules/juce_audio_basics/midi/ump/juce_UMPBytesOnGroup.h

@@ -0,0 +1,38 @@
+/*
+  ==============================================================================
+
+   This file is part of the JUCE library.
+   Copyright (c) 2022 - Raw Material Software Limited
+
+   JUCE is an open source library subject to commercial or open-source
+   licensing.
+
+   The code included in this file is provided under the terms of the ISC license
+   http://www.isc.org/downloads/software-support-policy/isc-license. Permission
+   To use, copy, modify, and/or distribute this software for any purpose with or
+   without fee is hereby granted provided that the above copyright notice and
+   this permission notice appear in all copies.
+
+   JUCE IS PROVIDED "AS IS" WITHOUT ANY WARRANTY, AND ALL WARRANTIES, WHETHER
+   EXPRESSED OR IMPLIED, INCLUDING MERCHANTABILITY AND FITNESS FOR PURPOSE, ARE
+   DISCLAIMED.
+
+  ==============================================================================
+*/
+
+namespace juce::universal_midi_packets
+{
+
+/**
+    Holds a UMP group, and a span of bytes that were received or are to be
+    sent on that group. Helpful when working with sysex messages.
+
+    @tags{Audio}
+*/
+struct BytesOnGroup
+{
+    uint8_t group{};
+    Span<const std::byte> bytes;
+};
+
+} // namespace juce::universal_midi_packets

JuceLibraryCode/modules/juce_audio_basics/midi/ump/juce_UMPDeviceInfo.h

@@ -0,0 +1,58 @@
+/*
+  ==============================================================================
+
+   This file is part of the JUCE library.
+   Copyright (c) 2022 - Raw Material Software Limited
+
+   JUCE is an open source library subject to commercial or open-source
+   licensing.
+
+   The code included in this file is provided under the terms of the ISC license
+   http://www.isc.org/downloads/software-support-policy/isc-license. Permission
+   To use, copy, modify, and/or distribute this software for any purpose with or
+   without fee is hereby granted provided that the above copyright notice and
+   this permission notice appear in all copies.
+
+   JUCE IS PROVIDED "AS IS" WITHOUT ANY WARRANTY, AND ALL WARRANTIES, WHETHER
+   EXPRESSED OR IMPLIED, INCLUDING MERCHANTABILITY AND FITNESS FOR PURPOSE, ARE
+   DISCLAIMED.
+
+  ==============================================================================
+*/
+
+namespace juce::universal_midi_packets
+{
+
+/**
+    Holds MIDI device info that may be required by certain UMP messages and
+    MIDI-CI messages.
+
+    @tags{Audio}
+*/
+struct DeviceInfo
+{
+    std::array<std::byte, 3> manufacturer;  ///< LSB first
+    std::array<std::byte, 2> family;        ///< LSB first
+    std::array<std::byte, 2> modelNumber;   ///< LSB first
+    std::array<std::byte, 4> revision;
+
+private:
+    auto tie() const { return std::tie (manufacturer, family, modelNumber, revision); }
+
+public:
+    bool operator== (const DeviceInfo& other) const { return tie() == other.tie(); }
+    bool operator!= (const DeviceInfo& other) const { return tie() != other.tie(); }
+
+    static constexpr auto marshallingVersion = std::nullopt;
+
+    template <typename Archive, typename This>
+    static auto serialise (Archive& archive, This& t)
+    {
+        return archive (named ("manufacturer", t.manufacturer),
+                        named ("family", t.family),
+                        named ("modelNumber", t.modelNumber),
+                        named ("revision", t.revision));
+    }
+};
+
+} // namespace juce::universal_midi_packets

JuceLibraryCode/modules/juce_audio_basics/midi/ump/juce_UMPFactory.h

@@ -55,10 +55,8 @@ struct Factory
 
             std::array<uint32_t, 2> words;
 
-            size_t index = 0;
-
-            for (auto& word : words)
-                word = ByteOrder::bigEndianInt (bytes.data() + 4 * index++);
+            for (const auto [index, word] : enumerate (words))
+                word = ByteOrder::bigEndianInt (bytes.data() + 4 * index);
 
             return PacketX2 { words };
         }
@@ -79,10 +77,8 @@ struct Factory
 
             std::array<uint32_t, 4> words;
 
-            size_t index = 0;
-
-            for (auto& word : words)
-                word = ByteOrder::bigEndianInt (bytes.data() + 4 * index++);
+            for (const auto [index, word] : enumerate (words))
+                word = ByteOrder::bigEndianInt (bytes.data() + 4 * index);
 
             return PacketX4 { words };
         }

JuceLibraryCode/modules/juce_audio_basics/midi/ump/juce_UMP_test.cpp

@@ -989,22 +989,12 @@ class UniversalMidiPacketTests final : public UnitTest
         }
     }
 
-   #if JUCE_WINDOWS && ! JUCE_MINGW
-    #define JUCE_CHECKED_ITERATOR(msg, size) \
-        stdext::checked_array_iterator<std::remove_reference_t<decltype (msg)>> ((msg), (size_t) (size))
-   #else
-    #define JUCE_CHECKED_ITERATOR(msg, size) (msg)
-   #endif
-
     static bool equal (const MidiMessage& a, const MidiMessage& b) noexcept
     {
         return a.getRawDataSize() == b.getRawDataSize()
-               && std::equal (a.getRawData(), a.getRawData() + a.getRawDataSize(),
-                              JUCE_CHECKED_ITERATOR (b.getRawData(), b.getRawDataSize()));
+               && std::equal (a.getRawData(), a.getRawData() + a.getRawDataSize(), b.getRawData());
     }
 
-    #undef JUCE_CHECKED_ITERATOR
-
     static bool equal (const MidiBuffer& a, const MidiBuffer& b) noexcept
     {
         return a.data == b.data;

JuceLibraryCode/modules/juce_audio_basics/mpe/juce_MPEZoneLayout.cpp

@@ -381,6 +381,17 @@ class MPEZoneLayoutTests final : public UnitTest
             expectEquals (layout.getLowerZone().numMemberChannels, 3);
             expectEquals (layout.getLowerZone().perNotePitchbendRange, 48);
             expectEquals (layout.getLowerZone().masterPitchbendRange, 2);
+
+            const auto masterPitchBend = 0x0c;
+            layout.processNextMidiEvent ({ 0xb0, 0x64, 0x00 });
+            layout.processNextMidiEvent ({ 0xb0, 0x06, masterPitchBend });
+
+            expectEquals (layout.getLowerZone().masterPitchbendRange, masterPitchBend);
+
+            const auto newPitchBend = 0x0d;
+            layout.processNextMidiEvent ({ 0xb0, 0x06, newPitchBend });
+
+            expectEquals (layout.getLowerZone().masterPitchbendRange, newPitchBend);
         }
     }
 };

JuceLibraryCode/modules/juce_audio_basics/utilities/juce_AudioWorkgroup.cpp

@@ -204,6 +204,21 @@ void AudioWorkgroup::join (WorkgroupToken& token) const
     token.reset();
 }
 
+size_t AudioWorkgroup::getMaxParallelThreadCount() const
+{
+   #if JUCE_AUDIOWORKGROUP_TYPES_AVAILABLE
+
+    if (@available (macos 11.0, ios 14.0, *))
+    {
+        if (auto wg = WorkgroupProvider::getWorkgroup (*this))
+            return (size_t) os_workgroup_max_parallel_threads (wg, nullptr);
+    }
+
+   #endif
+
+   return 0;
+}
+
 AudioWorkgroup::operator bool() const { return WorkgroupProvider::getWorkgroup (*this) != nullptr; }
 
 #if JUCE_AUDIOWORKGROUP_TYPES_AVAILABLE