card-piv.c - fix memory leak

dengert · dengert · commit a85b25a655ea · 2024-04-05T08:06:05.000-05:00
diff --git a/src/libopensc/card-piv.c b/src/libopensc/card-piv.c
@@ -5350,6 +5350,7 @@ piv_finish(sc_card_t *card)
 		piv_clear_sm_session(&priv->sm_session);
 #endif /* USE_PIV_SM */
 
+		free(priv->cert_signer_der);
 		free(priv);
 		card->drv_data = NULL; /* priv */
 	}
@@ -5927,7 +5928,7 @@ static int piv_init(sc_card_t *card)
 
 		/* If SM did not start, or is not expected to start, continue on without it */
 	}
-#endif /* USE_PIV_SM */
+#endif /* defined(USE_PIV_SM) || defined(USE_SM_NIST) */
 
 	/*
 	 * 800-73-3 cards may have a history object

Original file line number	Diff line number	Diff line change
`@@ -5350,6 +5350,7 @@ piv_finish(sc_card_t *card)`
`5350`	`5350`	`piv_clear_sm_session(&priv->sm_session);`
`5351`	`5351`	`#endif /* USE_PIV_SM */`
`5352`	`5352`
	`5353`	`+ free(priv->cert_signer_der);`
`5353`	`5354`	`free(priv);`
`5354`	`5355`	`card->drv_data = NULL; /* priv */`
`5355`	`5356`	`}`
`@@ -5927,7 +5928,7 @@ static int piv_init(sc_card_t *card)`
`5927`	`5928`
`5928`	`5929`	`/* If SM did not start, or is not expected to start, continue on without it */`
`5929`	`5930`	`}`
`5930`		`-#endif /* USE_PIV_SM */`
	`5931`	`+#endif /* defined(USE_PIV_SM) \|\| defined(USE_SM_NIST) */`
`5931`	`5932`
`5932`	`5933`	`/*`
`5933`	`5934`	`* 800-73-3 cards may have a history object`