chore: rename properties and ensure default values

Author: UlisesGascon

__tests__/checks/validators.test.js

@@ -148,9 +148,9 @@ describe('githubOrgMFA', () => {
 })
 
 describe('softwareDesignTraining', () => {
-  let softwareDesignTrainings, check, projects
+  let trainings, check, projects
   beforeEach(() => {
-    softwareDesignTrainings = [
+    trainings = [
       {
         project_id: 1,
         date: new Date().toISOString()
@@ -183,7 +183,7 @@ describe('softwareDesignTraining', () => {
   })
 
   it('Should generate a passed result if the project has a software design training and it is up to date', () => {
-    const analysis = softwareDesignTraining({ softwareDesignTrainings, check, projects })
+    const analysis = softwareDesignTraining({ trainings, check, projects })
     expect(analysis).toEqual({
       alerts: [],
       results: [
@@ -206,8 +206,8 @@ describe('softwareDesignTraining', () => {
     })
   })
   it('Should generate a failed result if the project has a software design training but it is out of date', () => {
-    softwareDesignTrainings[0].date = '2019-01-01'
-    const analysis = softwareDesignTraining({ softwareDesignTrainings, check, projects })
+    trainings[0].date = '2019-01-01'
+    const analysis = softwareDesignTraining({ trainings, check, projects })
     expect(analysis).toEqual({
       alerts: [
         {
@@ -246,8 +246,8 @@ describe('softwareDesignTraining', () => {
     })
   })
   it('Should generate a failed result if the project does not have a software design training', () => {
-    softwareDesignTrainings = []
-    const analysis = softwareDesignTraining({ softwareDesignTrainings, check, projects })
+    trainings = []
+    const analysis = softwareDesignTraining({ trainings, check, projects })
     expect(analysis).toEqual({
       alerts: [
         {
@@ -303,7 +303,7 @@ describe('softwareDesignTraining', () => {
     check.level_active_status = 'n/a'
     check.level_incubating_status = 'n/a'
     check.level_retiring_status = 'n/a'
-    const analysis = softwareDesignTraining({ softwareDesignTrainings, check, projects })
+    const analysis = softwareDesignTraining({ trainings, check, projects })
     expect(analysis).toEqual({
       alerts: [],
       results: [],

src/checks/validators/githubOrgMFA.js

@@ -4,7 +4,7 @@ const { getSeverityFromPriorityGroup, isCheckApplicableToProjectCategory, groupA
 const groupByProject = groupArrayItemsByCriteria('project_id')
 
 // @see: https://github.com/secure-dashboards/openjs-foundation-dashboard/issues/43
-module.exports = ({ organizations, check, projects }) => {
+module.exports = ({ organizations=[], check, projects=[] }) => {
   debug('Validating GitHub organizations MFA...')
   debug('Grouping organizations by project...')
   const organizationsGroupedByProject = groupByProject(organizations)

src/checks/validators/softwareDesignTraining.js

@@ -3,7 +3,7 @@ const { isCheckApplicableToProjectCategory, getSeverityFromPriorityGroup, isDate
 
 const expirationPolicy = '6m'
 
-module.exports = ({ softwareDesignTrainings, check, projects }) => {
+module.exports = ({ trainings=[], check, projects }) => {
   debug('Validating Software Design Training...')
   const alerts = []
   const results = []
@@ -28,7 +28,7 @@ module.exports = ({ softwareDesignTrainings, check, projects }) => {
     const task = { ...baseData }
     const alert = { ...baseData }
 
-    const trainingDetails = softwareDesignTrainings.find(training => training.project_id === project.id)
+    const trainingDetails = trainings.find(training => training.project_id === project.id)
     if (!trainingDetails) {
       result.status = 'failed'
       result.rationale = 'No Software Design Training found'