Skip to content

Commit 17eeaa5

Browse files
authored
Merge pull request #50 from secure-dashboards/ci/final-details
2 parents 1cf5c8e + 3008d06 commit 17eeaa5

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

.github/workflows/review-compliance-checks.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Check Migrations
1+
name: Check Compliance Checks
22

33
on:
44
pull_request:
@@ -11,7 +11,7 @@ permissions:
1111
pull-requests: write
1212

1313
jobs:
14-
check-migrations:
14+
check-compliance-checks:
1515
runs-on: ubuntu-latest
1616

1717
steps:

CONTRIBUTING.md

+19-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ You have several templates available:
2929

3030
## Pull Requests
3131

32+
### Create a good PR in this project
3233
Here are some recommendations for creating PRs in this project.
3334

3435
Creating a high-quality Pull Request (PR) helps maintainers review your contribution efficiently and ensures it aligns with the project's standards. Follow these steps to make your PR outstanding:
@@ -82,6 +83,23 @@ Before submitting your PR:
8283

8384
By following these steps, you'll create a high-quality PR that is easier to review and more likely to be accepted. Thank you for contributing!
8485

86+
### Additional Support
87+
88+
This project provides automatic comments in PRs when certain conditions are met. These comments include checklists to guide contributors through the required steps. Here are some examples:
89+
90+
**When a compliance check is added/modified**
91+
92+
The bot provides this checklist to ensure the updated compliance checks meet all project requirements.
93+
94+
![Checklist for compliance check updates with questions to validate changes, including schema generation, migrations, tests, and severity validation](https://github.com/user-attachments/assets/fb7fddbf-1592-4213-bf4d-821a7f8c8be8)
95+
96+
**When a migration is added/modified**
97+
98+
This checklist ensures that contributors validate schema generation and rollback behavior while avoiding edits to existing migrations.
99+
100+
![Checklist for migration updates with reminders about schema generation and rollback testing, and a note to avoid editing existing migrations](https://github.com/user-attachments/assets/169bea0d-b2aa-4c7e-84e2-9fb4f52ac289)
101+
102+
85103
## Current Initiatives
86104

87105
Here you can find the best ways to make meaningful contributions to the project.
@@ -156,4 +174,4 @@ By making a contribution to this project, I certify that:
156174
personal information I submit with it, including my sign-off) is
157175
maintained indefinitely and may be redistributed consistent with
158176
this project or the open source license(s) involved.
159-
```
177+
```

0 commit comments

Comments
 (0)