rector: EmptyOnNullableObjectToInstanceOfRector (#4876)

- see https://getrector.com/rule-detail/empty-on-nullable-object-to-instance-of-rector

Author: sreichel

.rector.php

@@ -133,9 +133,9 @@
             Strict\Empty_\DisallowedEmptyRuleFixerRector::class, # todo: TMP
             TypeDeclaration\BooleanAnd\BinaryOpNullableToInstanceofRector::class, # todo: TMP
             TypeDeclaration\ClassMethod\ReturnNeverTypeRector::class,
-            TypeDeclaration\Empty_\EmptyOnNullableObjectToInstanceOfRector::class, # todo: TMP
-            TypeDeclaration\StmtsAwareInterface\DeclareStrictTypesRector::class, # SKIP
-            # use static methods
+            # skip: cannot be applied to OpenMage codebase - yet
+            TypeDeclaration\StmtsAwareInterface\DeclareStrictTypesRector::class,
+            # skip: use static methods
             PreferPHPUnitThisCallRector::class,
             __DIR__ . '/shell/translations.php',
             __DIR__ . '/shell/update-copyright.php',

app/code/core/Mage/Admin/Model/Redirectpolicy.php

@@ -39,7 +39,7 @@ public function getRedirectUrl(
         ?Zend_Controller_Request_Http $request = null,
         $alternativeUrl = null
     ) {
-        if (empty($request)) {
+        if (!$request instanceof Zend_Controller_Request_Http) {
             return null;
         }
         $countRequiredParams = ($this->_urlModel->useSecretKey()

app/code/core/Mage/Shipping/Model/Carrier/Abstract.php

@@ -176,7 +176,7 @@ protected function _getAllowedContainers(?Varien_Object $params = null)
         if (empty($containersAll)) {
             return [];
         }
-        if (empty($params)) {
+        if (!$params instanceof Varien_Object) {
             return $containersAll;
         }
         $containersFilter   = $this->getContainerTypesFilter();