Change OpenMage version compare (#2839)

Author: sreichel

app/Mage.php

@@ -202,15 +202,13 @@ public static function getOpenMageVersion()
      */
     public static function getOpenMageVersionInfo()
     {
-        $majorVersion = 20;
-
         /**
          * This code construct is to make merging for forward porting of changes easier.
          * By having the version numbers of different branches in own lines, they do not provoke a merge conflict
          * also as releases are usually done together, this could in theory be done at once.
          * The major Version then needs to be only changed once per branch.
          */
-        if ($majorVersion === 20) { // @phpstan-ignore-line
+        if (self::getOpenMageMajorVersion() === 20) {
             return [
                 'major'     => '20',
                 'minor'     => '1',
@@ -229,6 +227,14 @@ public static function getOpenMageVersionInfo()
         ];
     }
 
+    /**
+     * @return int<19,20>
+     */
+    public static function getOpenMageMajorVersion(): int
+    {
+        return 19;
+    }
+
     /**
      * Get current Magento edition
      *
@@ -958,7 +964,6 @@ public static function getIsDeveloperMode()
     public static function printException(Throwable $e, $extra = '')
     {
         if (self::$_isDeveloperMode) {
-            @http_response_code(500);
             print '<pre>';
 
             if (!empty($extra)) {
@@ -1044,4 +1049,13 @@ public static function getScriptSystemUrl($folder, $exitIfNot = false)
 
         return $baseUrl;
     }
+
+    /**
+     * Set is downloader flag
+     *
+     * @deprecated
+     */
+    public static function setIsDownloader()
+    {
+    }
 }

phpstan.dist.neon

@@ -70,11 +70,6 @@ parameters:
 
         # Instantiated class not found
         - lib/Varien/Image/Adapter.php
-    ignoreErrors:
-      # OpenMage version comparison
-      -
-        message: "#^Strict comparison using \\=\\=\\= between 19 and 20 will always evaluate to false\\.$#"
-        path: app/Mage.php
     level: 4
     checkFunctionNameCase: true
     checkInternalClassCaseSensitivity: true