Fixed getAttributeRawValue return false if value is '0' (#572)

bastienlm · fballiano · commit 40dce4ca9bd9 · 2023-01-12T21:48:49.000Z
diff --git a/app/code/core/Mage/Catalog/Model/Resource/Abstract.php b/app/code/core/Mage/Catalog/Model/Resource/Abstract.php
@@ -575,7 +575,7 @@ protected function _prepareValueForSave($value, Mage_Eav_Model_Entity_Attribute_
      * @param int $entityId
      * @param int|string|array $attribute atrribute's ids or codes
      * @param int|Mage_Core_Model_Store $store
-     * @return bool|string|array
+     * @return bool|string|null|array
      */
     public function getAttributeRawValue($entityId, $attribute, $store)
     {
@@ -687,8 +687,7 @@ public function getAttributeRawValue($entityId, $attribute, $store)
         }
 
         if (count($attributesData) === 1 && !$returnArray) {
-            $_data = reset($attributesData);
-            $attributesData = $_data;
+            return reset($attributesData);
         }
 
         return $attributesData ? $attributesData : false;

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ protected function _prepareValueForSave($value, Mage_Eav_Model_Entity_Attribute_`
`575`	`575`	`* @param int $entityId`
`576`	`576`	`* @param int\|string\|array $attribute atrribute's ids or codes`
`577`	`577`	`* @param int\|Mage_Core_Model_Store $store`
`578`		`- * @return bool\|string\|array`
	`578`	`+ * @return bool\|string\|null\|array`
`579`	`579`	`*/`
`580`	`580`	`public function getAttributeRawValue($entityId, $attribute, $store)`
`581`	`581`	`{`
`@@ -687,8 +687,7 @@ public function getAttributeRawValue($entityId, $attribute, $store)`
`687`	`687`	`}`
`688`	`688`
`689`	`689`	`if (count($attributesData) === 1 && !$returnArray) {`
`690`		`- $_data = reset($attributesData);`
`691`		`- $attributesData = $_data;`
	`690`	`+ return reset($attributesData);`
`692`	`691`	`}`
`693`	`692`
`694`	`693`	`return $attributesData ? $attributesData : false;`