Skip to content

Feature: Add workflow to validate symbols #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
R1kaB3rN opened this issue Apr 8, 2025 · 2 comments
Open

Feature: Add workflow to validate symbols #282

R1kaB3rN opened this issue Apr 8, 2025 · 2 comments
Assignees
@R1kaB3rN

Comments

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Apr 8, 2025

For user gamefixes, we're currently only validating import statements in our CI. However, to prevent issues such as 8b1c250 we should validate symbols as well.
@R1kaB3rN R1kaB3rN self-assigned this Apr 8, 2025
@Root-Core
Copy link
Contributor

Root-Core commented Apr 8, 2025 •
edited
Loading

This should be possible after merging #201. We should then be able to enable type checking via pyright.
The relevant workflow was added in #205, type checking is disabled until the code base is compliant.

@Root-Core
Copy link
Contributor

Root-Core commented May 6, 2025 •
edited
Loading

As #201 is merged - where I already enabled static type checking - this issue could be closed. We should consider setting PyRight's ruleset to the strict preset though or to enable additional rules. I checked against strict, but there are ~90 issues and I have not looked into them yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R1kaB3rN R1kaB3rN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Root-Core @R1kaB3rN