Skip to content

[Feature Request] Cooling Fan Offset #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbienz opened this issue Apr 18, 2021 · 6 comments
Closed

[Feature Request] Cooling Fan Offset #149

jbienz opened this issue Apr 18, 2021 · 6 comments
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically type: enhancement New feature or request

Comments

@jbienz
Copy link

jbienz commented Apr 18, 2021

Similar to #61 which is temperature offset for filament, I'd also like to request part cooling fan offset. I don't know what we would assume is default (maybe 100%?) but it would likely need to be applied in a similar way. This would also require adding a cooling offset field to the spool information page.

Thanks for considering.
@jbienz jbienz changed the title Cooling Fan Offset [Feature Request] Cooling Fan Offset Apr 18, 2021
@OllisGit OllisGit added the status: waitingForFeedback Wating for Customers feedback label May 24, 2021
@OllisGit
Copy link
Owner

puhh.....OP doesn't support assigning offset for the fan. Maybe you can raise a request in the OP-Issue tracker.
After OP support this I can add this feature.

@jbienz
Copy link
Author

jbienz commented May 24, 2021

Maybe I'm confused. I thought the way tool temperature offset worked was by looking at the temperature set by the GCODE and adding or subtracting a number from it. I know cooling fan speed can be set, but are you saying there isn't a way for an OP plugin to get notified when GCODE makes a cooling fan speed update?

@OllisGit
Copy link
Owner

Hi @jbienz,

of course a plugin could listen to all gcode-lines and react on this...or even better OP provide an API where you can say: here is my offset "do the right thing"

The first part needs to be implement (UI + Server logic), testet and improved...or you choose an already proofed api.

.... and I am not sure how many people need this feature.

@OllisGit OllisGit added type: enhancement New feature or request and removed status: waitingForFeedback Wating for Customers feedback labels Oct 24, 2021
@github-actions
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Jan 13, 2022
@github-actions
Copy link

This issue was closed, because it has been already marked for 10 days with no activity.

@OllisGit
Copy link
Owner

Just for the records: When OP could provide an Fan-Offset-API I could be implemented. in SpoolMaager
OP Issue: OctoPrint/OctoPrint#3692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbienz @OllisGit