more test fixes

Author: rkapka

beacon-chain/blockchain/metrics_test.go

@@ -9,16 +9,6 @@ import (
 	"github.com/OffchainLabs/prysm/v6/testing/util"
 )
 
-func TestReportEpochMetrics_BadHeadState(t *testing.T) {
-	s, err := util.NewBeaconState()
-	require.NoError(t, err)
-	h, err := util.NewBeaconState()
-	require.NoError(t, err)
-	require.NoError(t, h.SetValidators(nil))
-	err = reportEpochMetrics(context.Background(), s, h)
-	require.ErrorContains(t, "failed to initialize precompute: state has nil validator slice", err)
-}
-
 func TestReportEpochMetrics_BadAttestation(t *testing.T) {
 	s, err := util.NewBeaconState()
 	require.NoError(t, err)

beacon-chain/core/altair/reward_test.go

@@ -31,7 +31,7 @@ func Test_BaseReward(t *testing.T) {
 			valIdx:    2,
 			st:        genState(1),
 			want:      0,
-			errString: "validator index 2 does not exist",
+			errString: "index 2 out of bounds",
 		},
 		{
 			name:      "active balance is 32eth",
@@ -89,7 +89,7 @@ func Test_BaseRewardWithTotalBalance(t *testing.T) {
 			valIdx:        2,
 			activeBalance: 1,
 			want:          0,
-			errString:     "validator index 2 does not exist",
+			errString:     "index 2 out of bounds",
 		},
 		{
 			name:          "active balance is 1",

container/multi-value-slice/multi_value_slice_test.go

@@ -476,6 +476,20 @@ func TestFragmentation_IndividualAndAppendedReferences(t *testing.T) {
 	assert.Equal(t, true, s.IsFragmented())
 }
 
+func TestNil(t *testing.T) {
+	obj := &testObject{}
+
+	s := &Slice[int]{}
+	s.Init(nil)
+	assert.Equal(t, 0, s.Len(obj))
+	assert.DeepEqual(t, []int{}, s.Value(obj))
+	_, err := s.At(obj, 0)
+	assert.NotNil(t, err)
+	s.Append(obj, 1)
+	assert.Equal(t, 1, s.Len(obj))
+	assert.DeepEqual(t, []int{1}, s.Value(obj))
+}
+
 // Share the slice between 2 objects.
 // Index 0: Shared value
 // Index 1: Different individual value