fix code for dirty rectangles

Author: akevalion

src/Roassal-Animation/RSTransitionAnimation.class.st

@@ -107,8 +107,7 @@ c
 
 	self onStepDo: [ :t |
 		object perform: sel withArguments: { t }.
-		canvas camera invalidate.
-		canvas signalUpdate
+		canvas invalidate
 	]
 ]
 

src/Roassal-Examples/RSBasicShapeExamples.class.st

@@ -1110,8 +1110,7 @@ RSBasicShapeExamples >> example44AA [
 			canvas host hasAntialiasing
 				ifTrue: [ canvas host disableAntialiasing ]
 				ifFalse: [ canvas host enableAntialiasing ].
-			canvas camera invalidate.
-			canvas signalUpdate ]
+			canvas invalidate]
 		for: self.
 	^ canvas
 ]

src/Roassal-Examples/RSHighlightableExamples.class.st

@@ -547,18 +547,18 @@ RSHighlightableExamples >> example12ShowingEdges [
 RSHighlightableExamples >> example13Click [
 
 	<script: 'self new example13Click open'>
-	| canvas shapes color interaction selectedItems interaction2 |
+	| canvas shapes color clickInteraction selectedItems highlightInteraction |
 	canvas := RSCanvas new.
-
+	canvas showDirtyRectangle.
 	color := RSColorPalette sequential bupu3.
 	shapes := (1 to: 20) collect: [ :m |
-		          RSBox new
-			          size: 10;
-			          model: m;
-			          draggable;
-			          withBorder;
-			          color: (color scale: m);
-			          yourself ].
+		RSBox new
+			size: 10;
+			model: m;
+			draggable;
+			withBorder;
+			color: (color scale: m);
+			yourself ].
 
 	RSLineBuilder line
 		canvas: canvas;
@@ -568,7 +568,8 @@ RSHighlightableExamples >> example13Click [
 
 	selectedItems := OrderedCollection new.
 
-	interaction := RSHighlightable red withLines.
+	clickInteraction := RSHighlightable red withLines.
+	highlightInteraction := RSHighlightable red withLines.
 	canvas nodes
 		when: RSMouseLeftClick
 		do: [ :evt |
@@ -577,18 +578,18 @@ RSHighlightableExamples >> example13Click [
 			(selectedItems includes: shape)
 				ifTrue: [ selectedItems remove: shape ]
 				ifFalse: [ selectedItems add: shape ].
-			interaction doHighlightShapes: selectedItems.
+			highlightInteraction unhighlightRecordedShapes: evt canvas.
+			clickInteraction doHighlightShapes: selectedItems.
 			evt signalUpdate ]
 		for: self.
 	canvas
 		when: RSMouseClick
 		do: [ :evt |
 			selectedItems removeAll.
-			interaction unhighlightRecordedShapes: evt.
+			clickInteraction unhighlightRecordedShapes: evt.
 			evt signalUpdate ]
 		for: self.
-	interaction2 := RSHighlightable red withLines.
-	canvas nodes @ interaction2.
+	canvas nodes @ highlightInteraction.
 	RSClusterTreeLayout on: shapes.
 	canvas zoomToFit.
 	^ canvas

src/Roassal-Examples/RSLayoutExamples.class.st

@@ -627,13 +627,13 @@ RSLayoutExamples >> example20FlowLayout [
 		canvas shouldShowEncompassingRectangles
 			ifTrue: [ canvas hideEncompassingRectangles ]
 			ifFalse: [ canvas showEncompassingRectangles ].
-		canvas camera invalidate. canvas signalUpdate ].
+		canvas invalidate ].
 		'Show/Hide Underlines'.
 		[
 		labels first isUnderlined
 			ifTrue: [ labels do: #normal ]
 			ifFalse: [ labels do: #underline ].
-		canvas camera invalidate. canvas signalUpdate
+		canvas invalidate
 		] } pairsDo: [ :s :a |
 		(newLabel value: s)
 			fontSize: 12;

src/Roassal-Interaction/RSHighlightable.class.st

@@ -317,8 +317,10 @@ c @ RSCanvasController
 ```
 	"
 	self
-		when: RSHighlightEvent do: [ :evt | self record: evt shape selector: #color value: aColor ] for: self;
-		when: RSUnHighlightEvent do: [ :evt | self restore: evt shape selector: #color ] for: self
+		when: RSHighlightEvent do: [ :evt | 
+			self record: evt shape selector: #color value: aColor ] for: self;
+		when: RSUnHighlightEvent do: [ :evt | 
+			self restore: evt shape selector: #color ] for: self
 ]
 
 { #category : 'accessing' }
@@ -438,7 +440,7 @@ For example:
 	savedValues := aShape properties
 		at: self copyKey , selector
 		ifAbsentPut: [ OrderedCollection new ].
-	savedValues add: (aShape perform: selector).
+	savedValues add: (selector value: aShape).
 
 	aShape
 		perform: selector asMutator

src/Roassal-Interaction/RSZoomableCanvasInteraction.class.st

@@ -56,8 +56,7 @@ RSZoomableCanvasInteraction class >> zoomMove: aCanvas pixelPosition: morphPosit
 		zero := camera fromSpaceToPixel: 0@0.
 		camera matrix translation: morphPosition - (newPosition - zero)-(camera originMode gapDistance: camera).
 
-		camera invalidate.
-		aCanvas signalUpdate.
+		aCanvas invalidate.
 		^ self ].
 	aCanvas newAnimation
 		easing: RSEasingInterpolator backOut;
@@ -70,8 +69,7 @@ RSZoomableCanvasInteraction class >> zoomMove: aCanvas pixelPosition: morphPosit
 			zero := camera fromSpaceToPixel: 0@0.
 			camera matrix translation: morphPosition - (newPosition - zero)-(camera originMode gapDistance: camera).
 
-			camera invalidate.
-			aCanvas signalUpdate ]
+			aCanvas invalidate ]
 ]
 
 { #category : 'configuration' }