Fix tests that fail from new Xarray variable and attribute assignment updates (#1433)

* add .values to change water level scalar value

* add .values to fillna

* fix assign attributes

* remove test1

* update echodata properly

* remove print statement

Author: ctuguinay

echopype/tests/consolidate/test_add_depth.py

@@ -196,7 +196,7 @@ def test_ek_depth_utils_group_variable_NaNs_logger_warnings(caplog):
     ds_Sv = ep.calibrate.compute_Sv(ed, **{"waveform_mode":"CW", "encode_mode":"power"})
 
     # Set first index of group variables to NaN
-    ed["Platform"]["water_level"] = np.nan # Is a scalar
+    ed["Platform"]["water_level"].values = np.nan # Is a scalar
     ed["Platform"]["vertical_offset"].values[0] = np.nan
     ed["Platform"]["transducer_offset_z"].values[0] = np.nan
     ed["Platform"]["pitch"].values[0] = np.nan
@@ -337,7 +337,7 @@ def test_add_depth_errors():
     with pytest.raises(NotImplementedError, match=(
         "`use_platform/beam_...` not implemented yet for `AZFP`."
     )):
-        ed["Sonar"].attrs["sonar_model"] = "AZFP"
+        ed["Sonar"] = ed["Sonar"].assign_attrs(sonar_model="AZFP")
         ep.consolidate.add_depth(ds_Sv, ed, use_platform_angles=True)
 
 
@@ -375,9 +375,9 @@ def test_add_depth_EK_with_platform_vertical_offsets(file, sonar_model, compute_
     ds_Sv = ds_Sv.isel(range_sample=slice(0,5))
 
     # Replace any Platform Vertical Offset NaN values with 0
-    ed["Platform"]["water_level"] = ed["Platform"]["water_level"].fillna(0)
-    ed["Platform"]["vertical_offset"] = ed["Platform"]["vertical_offset"].fillna(0)
-    ed["Platform"]["transducer_offset_z"] = ed["Platform"]["transducer_offset_z"].fillna(0)
+    ed["Platform"]["water_level"].values = ed["Platform"]["water_level"].fillna(0).values
+    ed["Platform"]["vertical_offset"].values = ed["Platform"]["vertical_offset"].fillna(0).values
+    ed["Platform"]["transducer_offset_z"].values = ed["Platform"]["transducer_offset_z"].fillna(0).values
 
     # Compute `depth` using platform vertical offset values
     ds_Sv_with_depth = ep.consolidate.add_depth(ds_Sv, ed, use_platform_vertical_offsets=True)
@@ -431,8 +431,8 @@ def test_add_depth_EK_with_platform_angles(file, sonar_model, compute_Sv_kwargs)
     ds_Sv = ep.calibrate.compute_Sv(ed, **compute_Sv_kwargs)
 
     # Replace any Beam Angle NaN values with 0
-    ed["Platform"]["pitch"] = ed["Platform"]["pitch"].fillna(0)
-    ed["Platform"]["roll"] = ed["Platform"]["roll"].fillna(0)
+    ed["Platform"]["pitch"].values = ed["Platform"]["pitch"].fillna(0).values
+    ed["Platform"]["roll"].values = ed["Platform"]["roll"].fillna(0).values
 
     # Compute `depth` using platform angle values
     ds_Sv_with_depth = ep.consolidate.add_depth(ds_Sv, ed, use_platform_angles=True)
@@ -485,9 +485,9 @@ def test_add_depth_EK_with_beam_angles(file, sonar_model, compute_Sv_kwargs):
     ds_Sv = ep.calibrate.compute_Sv(ed, **compute_Sv_kwargs)
 
     # Replace Beam Angle NaN values
-    ed["Sonar/Beam_group1"]["beam_direction_x"] = ed["Sonar/Beam_group1"]["beam_direction_x"].fillna(0)
-    ed["Sonar/Beam_group1"]["beam_direction_y"] = ed["Sonar/Beam_group1"]["beam_direction_y"].fillna(0)
-    ed["Sonar/Beam_group1"]["beam_direction_z"] = ed["Sonar/Beam_group1"]["beam_direction_z"].fillna(1)
+    ed["Sonar/Beam_group1"]["beam_direction_x"].values = ed["Sonar/Beam_group1"]["beam_direction_x"].fillna(0).values
+    ed["Sonar/Beam_group1"]["beam_direction_y"].values = ed["Sonar/Beam_group1"]["beam_direction_y"].fillna(0).values
+    ed["Sonar/Beam_group1"]["beam_direction_z"].values = ed["Sonar/Beam_group1"]["beam_direction_z"].fillna(1).values
 
     # Compute `depth` using beam angle values
     ds_Sv_with_depth = ep.consolidate.add_depth(ds_Sv, ed, use_beam_angles=True)