Refactor Echoview NASC export

[leewujung]

Now that we have the initial refactoring design, let’s go ahead to get the subpackages completed one by one.

The first one (and probably the most straightforward) is the ingest_nasc module.

Below are some tasks I can think of on top of head, the basic items will be the same for each subpackage, but there will some that need more adjustment than the others. @brandynlucca if you run into anything feel free to ping me here or on slack.

I think at this stage we just need to make sure the functions are in place and don’t need to worry about how they are hooked up from the config files or validating variables. From the workflow file I am confident that we can back out the config easily and add the validators later.

Testing

• These can be more in the form of unit test. Don’t need to go overboard on detailed testing but make sure the core functionality is tested (for example the computed values or the dimension shape of the output)
• For the ingestion function, I think it’ll be useful to construct minimum excel files that each capture the columns and rows (eg strata) the function actually need, and use simple values for these, instead of trying to replicate all columns/rows or use actual data files.
• For example: all entries in a given stratum that are a single identical number, so the output value is easy to determine and can be tested exactly.

Tasks

• Complete all functions by moving current code and make necessary adjustments
• Ensure each function has tests

[leewujung]

Oh and @brandynlucca please request me to review the PR.