fix: raster import and TimeSeriesMap rendering issues #5416
Conversation
github-actions
bot
added
temporal
sudhanshu112233shukla
changed the title
|
I tested it, but it doesn't help. I think this will need larger changes. |
|
@petrasovaa can you guide me , or give me some overview I will try my best to solve this. |
|
TimeSeriesMap and SeriesMap were written separately and then later we created a BaseSeriesMap because they have a lot in common. But that was not done entirely correctly, some of the TSM structures are different then the SM, which is somehow causing the bug. So I would look at the rendering commands when they are called. |
…3shukla/grass into codefixes" This reverts commit 7e42dbd, reversing changes made to 420720a.
There was a problem hiding this comment.
@petrasovaa test it ma'am .
There was a problem hiding this comment.
Please fix the formatting issue first. I am not convinced this will work, could you post here a quick screencast showing TimeSeriesMap and SeriesMap example with your changes? We have example notebooks in doc/examples/notebooks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
| @@ -28,7 +28,8 @@ | |||
| from .utils import get_number_of_cores, save_gif | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| @@ -98,13 +99,30 @@ | |||
| self._base_calls.append((grass_module, kwargs)) | |||
|
|
|||
| return wrapper | |||
|
|
|||
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| self._layers_rendered = False # Force re-render | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| self._layers_rendered = False # Force re-render | |
| self._layers_rendered = False # Force re-render |
| def _apply_overlays(self, img): | ||
| """Apply overlay commands (d.vect, d.barscale) to map instance""" | ||
| for grass_module, kwargs in self._base_calls: | ||
| img.run(grass_module, **kwargs) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| img.run(grass_module, **kwargs) | |
| img.run(grass_module, **kwargs) |
| img.d_legend(**self._legend) | ||
|
|
||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| img.d_legend(**self._legend) | |
| img.d_legend(**self._legend) | |
|
|
||
| # Create instance | ||
| precip_map = TimeSeriesMap(use_region=True) | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
|
|
||
| # Add raster series | ||
| precip_map.add_raster_series("precip_sum_2018") | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| precip_map.d_vect(map="boundary_country", fill_color="none") | ||
| precip_map.d_barscale() | ||
| precip_map.d_legend(color="black", at=(10, 40, 2, 6)) | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
|
|
||
| # Render frames (headless) | ||
| precip_map.render() | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
| # Verify layers | ||
| assert precip_map._layers is not None, "No layers loaded" | ||
| assert len(precip_map._layers) > 0, "Layers list is empty" | ||
|
|
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
grass/python/grass/jupyter/seriesmap.py
Line 17 in 4920b44
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Resolved raster import failure and corrected TimeSeriesMap rendering by handling dataset accessibility and granularity errors. Closes #5304 .