style: Fixed ruff formatting errors in wxGUI/gcp (#5082)

* added path.glob()

* wrapped item.name in str

* removed str wrapper

Author: arohanajit

gui/wxpython/gcp/manager.py

@@ -33,6 +33,7 @@
 import shutil
 import sys
 from copy import copy
+from pathlib import Path
 from typing import TYPE_CHECKING
 
 import wx
@@ -466,16 +467,12 @@ def OnLocation(self, event):
         self.xylocation = event.GetString()
 
         # create a list of valid mapsets
-        tmplist = os.listdir(os.path.join(self.grassdatabase, self.xylocation))
+        location_path = Path(self.grassdatabase) / self.xylocation
         self.mapsetList = []
-        for item in tmplist:
-            if os.path.isdir(
-                os.path.join(self.grassdatabase, self.xylocation, item)
-            ) and os.path.exists(
-                os.path.join(self.grassdatabase, self.xylocation, item, "WIND")
-            ):
-                if item != "PERMANENT":
-                    self.mapsetList.append(item)
+        for item in location_path.iterdir():
+            if item.is_dir() and (item / "WIND").exists():
+                if item.name != "PERMANENT":
+                    self.mapsetList.append(item.name)
 
         self.xymapset = "PERMANENT"
         utils.ListSortLower(self.mapsetList)
@@ -697,25 +694,13 @@ def OnEnterPage(self, event: WizardEvent | None = None) -> None:
         self.xymapset = self.parent.gisrc_dict["MAPSET"]
 
         # create a list of groups in selected mapset
-        if os.path.isdir(
-            os.path.join(self.grassdatabase, self.xylocation, self.xymapset, "group")
-        ):
-            tmplist = os.listdir(
-                os.path.join(
-                    self.grassdatabase, self.xylocation, self.xymapset, "group"
-                )
-            )
-            for item in tmplist:
-                if os.path.isdir(
-                    os.path.join(
-                        self.grassdatabase,
-                        self.xylocation,
-                        self.xymapset,
-                        "group",
-                        item,
-                    )
-                ):
-                    self.groupList.append(item)
+        group_path = (
+            Path(self.grassdatabase) / self.xylocation / self.xymapset / "group"
+        )
+        if group_path.is_dir():
+            for item in group_path.iterdir():
+                if item.is_dir():
+                    self.groupList.append(item.name)
 
         if maptype == "raster":
             self.btn_vgroup.Hide()
@@ -2032,8 +2017,8 @@ def RMSError(self, xygroup, order):
         highest_idx = 0
 
         for index in range(self.list.GetItemCount()):
-            key = self.list.GetItemData(index)
             if self.list.IsItemChecked(index):
+                key = self.list.GetItemData(index)
                 fwd_err, bkw_err = errlist[GCPcount].split()
                 self.list.SetItem(index, 5, fwd_err)
                 self.list.SetItem(index, 6, bkw_err)
@@ -2620,21 +2605,14 @@ def __init__(
         #
         # get list of valid vector directories
         #
-        vectlist = os.listdir(
-            os.path.join(self.grassdatabase, self.xylocation, self.xymapset, "vector")
-        )
-        for dir in vectlist:
-            if not os.path.isfile(
-                os.path.join(
-                    self.grassdatabase,
-                    self.xylocation,
-                    self.xymapset,
-                    "vector",
-                    dir,
-                    "coor",
-                )
-            ):
-                vectlist.remove(dir)
+        vector_path = (
+            Path(self.grassdatabase) / self.xylocation / self.xymapset / "vector"
+        )
+        vectlist = [
+            coor_path.parent.name
+            for coor_path in vector_path.glob("*/coor")
+            if coor_path.is_file()
+        ]
 
         utils.ListSortLower(vectlist)
 

pyproject.toml

@@ -284,7 +284,6 @@ ignore = [
 # Other ignores:
 "**.py" = ["PYI066"]
 "*/testsuite/**.py" = ["PT009", "PT027"]
-"gui/wxpython/gcp/manager.py" = ["PTH208"]
 "gui/wxpython/gui_core/dialogs.py" = ["PTH208"]
 "gui/wxpython/gui_core/forms.py" = ["SIM115"]
 "gui/wxpython/gui_core/goutput.py" = ["SIM115"]