Skip to content

[Bug] - CI end to end tests are not showing docker log output #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaSBrown opened this issue May 13, 2025 · 0 comments · Fixed by #1426
Open

[Bug] - CI end to end tests are not showing docker log output #1425

JoshuaSBrown opened this issue May 13, 2025 · 0 comments · Fixed by #1426
Labels
Type: Bug Something isn't working

Comments

@JoshuaSBrown
Copy link
Collaborator

JoshuaSBrown commented May 13, 2025

Description

There is a typo in the gitlab ci jobs preventing docker logs from being output, on completion or failure of the end to end tests. In a multiline gitlab yaml file

    - MATCHING_CONTAINERS=$( echo "$ANCESTOR_CONTAINERS" | grep "${COMPONENT}-${BRANCH_LOWER}" || echo "")
    - if [ -z "$MATCHING_CONTAINERS" ]; then
        echo "No matching containers found for image ${FULL_IMAGE_NAME} and component ${COMPONENT}-${BRANCH_LOWER}";
      else
        echo "Getting log output for the following."
        echo "$MATCHING_CONTAINERS"
        docker logs $MATCHING_CONTAINERS;
      fi

Each shell line needs to be postpended with a ';' otherwise they get grouped together, what is happening here, is the echo statement in the previous lines are getting clumped together with the docker logs.

This is what is getting printed:

Getting log output for the following. echo gcs-fix-ci-build-b5d65087-ZQZ53jCalF docker logs gcs-fix-ci-build-b5d65087-ZQZ53jCalF

Instead of teh commands getting executed.

Steps to Replicate

Additional context

Page occured:

Expected behavior

Artifacts (if appropriate):

@JoshuaSBrown JoshuaSBrown added the Type: Bug Something isn't working label May 13, 2025
@JoshuaSBrown JoshuaSBrown linked a pull request May 13, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant