Skip to content

1396 add missing python module #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

JoshuaSBrown
Copy link
Collaborator

PR Description

New version of protobuf leads to errors if tzdata module is missing. This PR adds it as part of the protobuf install.

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

@JoshuaSBrown JoshuaSBrown requested a review from nedvedba April 30, 2025 20:32
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We failed to fetch the diff for pull request #1404

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@JoshuaSBrown JoshuaSBrown changed the base branch from master to devel April 30, 2025 20:32
@JoshuaSBrown JoshuaSBrown self-assigned this Apr 30, 2025
@JoshuaSBrown JoshuaSBrown added Component: Build Related to the build system Component: CI labels May 1, 2025
Copy link
Collaborator

@AronPerez AronPerez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!!!

@JoshuaSBrown JoshuaSBrown merged commit 80239fa into devel May 5, 2025
10 of 11 checks passed
@JoshuaSBrown JoshuaSBrown deleted the 1396-add-missing-python-module branch May 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Related to the build system Component: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug, CI] - Protobuf dependency complains about missing python module
2 participants