Merge PR #894 into 16.0

Signed-off-by jbaudoux

Author: OCA-git-bot

stock_available_to_promise_release/models/stock_move.py

@@ -313,14 +313,23 @@ def _is_release_needed(self):
     def _is_release_ready(self):
         """Checks if a move itself is ready for release
         without considering the picking release_ready
+
+
+        Be careful, when calling this method, you must ensure that the
+        'ordered_available_to_promise_qty' field is up to date. If not,
+        you should invalidate the cache before calling this method. This
+        is not done automatically to avoid unnecessary cache invalidation
+        and to allow batch computation. The `_is_release_ready` method
+        is designed to be called on a single record. If we do the cache
+        invalidation here, it would be done for each record, which means
+        that the computation of the 'ordered_available_to_promise_qty'
+        would be done for each record, which is not efficient.
         """
         self.ensure_one()
         if not self._is_release_needed() or self.state == "draft":
             return False
         release_policy = self.picking_id.release_policy
         rounding = self.product_id.uom_id.rounding
-        # computed field has no depends set, invalidate cache before reading
-        self.invalidate_recordset(["ordered_available_to_promise_qty"])
         ordered_available_to_promise_qty = self.ordered_available_to_promise_qty
         if release_policy == "one":
             return (
@@ -349,6 +358,7 @@ def _get_release_ready_depends(self):
 
     @api.depends(lambda self: self._get_release_ready_depends())
     def _compute_release_ready(self):
+        self.invalidate_recordset(["ordered_available_to_promise_qty"])
         for move in self:
             release_ready = move._is_release_ready()
             if release_ready and move.picking_id.release_policy == "one":

stock_available_to_promise_release/models/stock_picking.py

@@ -82,6 +82,7 @@ def _get_release_ready_depends(self):
     # invalidate cache before accessing this release_ready computed value
     @api.depends(lambda self: self._get_release_ready_depends())
     def _compute_release_ready(self):
+        self.move_ids.invalidate_recordset(["ordered_available_to_promise_qty"])
         for picking in self:
             moves = picking.move_ids.filtered(lambda move: move._is_release_needed())
             release_ready = False