Skip to content

Principle #6 definitions - automated validation #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beckyjackson opened this issue Aug 9, 2019 · 4 comments
Closed

Principle #6 definitions - automated validation #1010

beckyjackson opened this issue Aug 9, 2019 · 4 comments
Assignees
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles

Comments

@beckyjackson
Copy link
Contributor

FP 6 - Textual Definitions

Automated checks:

  1. Each definition must be unique
  2. No entity may have more than one defintion
  3. Each entity should have a definition
  4. Definitions should follow Aristotelian form

Mechanism:

Checks 1 through 3 are implemented by ROBOT report. We can run the report and look at the results of these three checks. The first two (duplicate and multiple definitions) are failures. The third (missing definitions) is a warning.

Check 4 is a bit more difficult to implement and I'm not sure if it is practical to do this right now.

@beckyjackson beckyjackson added attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools labels Aug 9, 2019
@beckyjackson beckyjackson self-assigned this Aug 9, 2019
@nataled
Copy link
Contributor

nataled commented Sep 24, 2019

From EWG discussion on this:

Need to account for special cases (like structures in CHEBI) or alternatives to definitions (such as elucidations in BFO).

@beckyjackson
Copy link
Contributor Author

ROBOT's report checks for elucidations as well, for example: http://robot.obolibrary.org/report_queries/missing_definition

We do not have a special case for ChEBI structures though. What is the relevant property for this? Are there other special cases that we need to consider?

@nataled
Copy link
Contributor

nataled commented Sep 27, 2019

The CHEBI case and BFO cases were the only ones discussed (these discussions happened several years ago, well before there even was ROBOT, and I just wanted to bring the discussion out of the internal document and into the tracker).

I don't know what the relevant property would be. Not sure there even is one to look for. But, we knew that CHEBI (and probably the new glycan ontology) would have problems meeting this principle due to the nature of their "definitions."

@cmungall cmungall added the principles Issues related to Foundry principles label Nov 22, 2019
@cmungall cmungall changed the title Principle #6 automated validation Principle #6 definitions - automated validation Nov 22, 2019
@wdduncan wdduncan added the automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. label Apr 28, 2020
@nataled
Copy link
Contributor

nataled commented Feb 15, 2022

Closed because the automated check is already in place and functioning properly for nearly all ontologies, with only CHEBI as an exception. A separate ticket has been opened for that (#1802).

@nataled nataled closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles
Projects
None yet
Development

No branches or pull requests

4 participants