Fix disabled linter warnings

Author: mrlika

packages/p2p-media-loader-core/src/declarations.d.ts

@@ -16,11 +16,6 @@ declare module "bittorrent-tracker" {
     ): void;
 
     start(): void;
-
-    complete(): void;
-
-    update(data?: object): void;
-
     destroy(): void;
   }
 

packages/p2p-media-loader-core/src/p2p/loader.ts

@@ -89,8 +89,8 @@ export class P2PLoader {
 
   get connectedPeerCount() {
     let count = 0;
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    for (const peer of this.trackerClient.peers()) count++;
+    const iterator = this.trackerClient.peers();
+    while (!iterator.next().done) count++;
     return count;
   }
 

packages/p2p-media-loader-core/src/p2p/tracker-client.ts

@@ -82,14 +82,16 @@ export class P2PTrackerClient {
 
   destroy() {
     this.client.destroy();
+
     for (const { peer, potentialConnections } of this._peers.values()) {
       peer?.destroy();
       for (const connection of potentialConnections) {
         connection.destroy();
       }
     }
+
     this._peers.clear();
-    this.logger(`destroy client; stream: ${this.streamShortId}`);
+    this.logger("destroy client; stream:", this.streamShortId);
   }
 
   private onReceivePeerConnection: TrackerClientEvents["peer"] = (
@@ -141,17 +143,15 @@ export class P2PTrackerClient {
   private onTrackerClientWarning: TrackerClientEvents["warning"] = (
     warning,
   ) => {
-    // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-    this.logger(`tracker warning (${this.streamShortId}: ${warning})`);
+    this.logger("tracker warning %s:", this.streamShortId, warning);
     this.eventTarget.getEventDispatcher("onTrackerWarning")({
       streamType: this.stream.type,
       warning,
     });
   };
 
   private onTrackerClientError: TrackerClientEvents["error"] = (error) => {
-    // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-    this.logger(`tracker error (${this.streamShortId}: ${error})`);
+    this.logger("tracker error in stream %s:", this.streamShortId, error);
     this.eventTarget.getEventDispatcher("onTrackerError")({
       streamType: this.stream.type,
       error,